bug fix: write_from doesn't propogate result to caller (#1884)

dstaay-fb · meta-codesync[bot] · commit 36c05794d035 · 2025-11-17T18:39:43.000-08:00
Summary: Pull Request resolved: #1884 Clear bug, we swallow possible errors from write_from operations. Reviewed By: allenwang28, mariusae Differential Revision: D87037246 fbshipit-source-id: 79e8c6f337470346574f9e9aed3f7175bdc3f5a0
diff --git a/monarch_rdma/src/rdma_components.rs b/monarch_rdma/src/rdma_components.rs
@@ -207,8 +207,7 @@ impl RdmaBuffer {
             .release_queue_pair(client, remote_owner, local_device, remote_device, qp)
             .await?;
 
-        result?;
-        Ok(true)
+        result
     }
     /// Waits for the completion of an RDMA operation.
     ///

Original file line number	Diff line number	Diff line change
`@@ -207,8 +207,7 @@ impl RdmaBuffer {`
`207`	`207`	`.release_queue_pair(client, remote_owner, local_device, remote_device, qp)`
`208`	`208`	`.await?;`
`209`	`209`
`210`		`- result?;`
`211`		`- Ok(true)`
	`210`	`+ result`
`212`	`211`	`}`
`213`	`212`	`/// Waits for the completion of an RDMA operation.`
`214`	`213`	`///`