Skip to content

E290Display.cpp hardcodes setRotation(3); apply same runtime-rotation pattern as merged E213 PR #2394

@chrisfore

Description

@chrisfore

src/helpers/ui/E290Display.cpp:12 hardcodes display.setRotation(3), same pattern fixed for E213 in #2393. After that PR lands, display_rotation is already in NodePrefs and CLI-addressable — the missing piece is wiring the same override into E290Display (store rotation in a member, apply in begin(), override the virtual setRotation on the base class).

Not picking this up here because I have no E290 hardware to verify the override actually takes effect. Filing so someone with the board can take it on with a short PR.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions