[WC-2686] Fix flashing text content when custom content is set for list and selection selection #1973
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r0b1n
force-pushed
the
fix/combobox-custom-content
branch
3 times, most recently
from
6f755f8 to
4e5a071
Compare
samuelreichert
previously approved these changes
Nov 12, 2025
r0b1n
force-pushed
the
fix/combobox-custom-content
branch
from
4e5a071 to
02c72c9
Compare
r0b1n
force-pushed
the
fix/combobox-custom-content
branch
from
02c72c9 to
64dadbc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Bug fix (non-breaking change which fixes an issue)
Description
This prevents autofilling input with text, so user should not see flashing of the text representation of the options with custom selection.
What should be covered while testing?
Check that combobox still functions and behaves as expected in single selection mode with different settings for custom content (Yes/List only/No) with Filter enabled and disabled (set to None).
Check if focusing behavior is working as expected for empty and selected states with different combinations from the above cases.