Skip to content

Commit 4538743

Browse files
committed
fix: resolve type issues & update changelog
1 parent 7bdd0d7 commit 4538743

File tree

3 files changed

+13
-8
lines changed

3 files changed

+13
-8
lines changed

packages/pluggableWidgets/barcode-generator-web/CHANGELOG.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,11 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
66

77
## [Unreleased]
88

9+
### Added
10+
11+
- Comprehensive configuration and styling settings for various barcode types
12+
- Download functionality for barcodes
13+
914
## [1.0.0] - 2025-10-09
1015

1116
### Added

packages/pluggableWidgets/barcode-generator-web/src/components/CodeRenderer.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,8 @@ interface CodeRendererProps {
2727
qrimageWidth: number;
2828
qrimageOpacity: number;
2929
qrimageExcavate: boolean;
30-
svgRef: RefObject<SVGSVGElement>;
31-
qrContainerRef: RefObject<HTMLDivElement>;
30+
svgRef: RefObject<SVGSVGElement | null>;
31+
qrContainerRef: RefObject<HTMLDivElement | null>;
3232
}
3333

3434
export function CodeRenderer({
@@ -62,7 +62,7 @@ export function CodeRenderer({
6262
if (format === "QRCode") {
6363
return (
6464
<QRCodeRenderer
65-
ref={qrContainerRef}
65+
ref={qrContainerRef as RefObject<HTMLDivElement>}
6666
value={value}
6767
size={qrsize}
6868
margin={qrmargin}
@@ -94,7 +94,7 @@ export function CodeRenderer({
9494
addonValue={addonValue}
9595
addonFormat={addonFormat}
9696
addonSpacing={addonSpacing}
97-
ref={svgRef}
97+
ref={svgRef as RefObject<SVGSVGElement>}
9898
/>
9999
);
100100
}

packages/pluggableWidgets/barcode-generator-web/src/hooks/useDownload.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,17 +13,17 @@ const FILENAMES = {
1313

1414
interface UseDownloadParams {
1515
format: string;
16-
svgRef: RefObject<SVGSVGElement>;
17-
qrContainerRef: RefObject<HTMLDivElement>;
16+
svgRef: RefObject<SVGSVGElement | null>;
17+
qrContainerRef: RefObject<HTMLDivElement | null>;
1818
}
1919
interface UseDownloadReturn {
2020
downloadSVG: () => Promise<void>;
2121
}
2222

2323
const getSvgElement = (
2424
format: string,
25-
svgRef: RefObject<SVGSVGElement>,
26-
qrContainerRef: RefObject<HTMLDivElement>
25+
svgRef: RefObject<SVGSVGElement | null>,
26+
qrContainerRef: RefObject<HTMLDivElement | null>
2727
): SVGSVGElement | null => {
2828
if (format === "QRCode") {
2929
return qrContainerRef.current?.querySelector("svg") || null;

0 commit comments

Comments
 (0)