Skip to content

Commit 69f92e4

Browse files
feat: add node 16 support, remove node 12 (#265)
* feat: add node 16, 18 support, remove node 12 - Changed CONTRIBUTING.md - Change tests to run on 14, 16, 18 - Execute publish with Node 14 - In the playground NODE_OPTIONS must be set to legacy provider, because webpack 4 (used by vuepress) doesn't support node > 16 Fixes #229 Fixes #246 * fix: remove node 18 support * fix: change bors.toml to node 14 and node 16 Co-authored-by: cvermand <33010418+bidoubiwa@users.noreply.github.com>
1 parent 40764bb commit 69f92e4

File tree

6 files changed

+15
-7
lines changed

6 files changed

+15
-7
lines changed

.github/workflows/npm-publish.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ jobs:
1414
run: sh .github/scripts/check-release.sh
1515
- uses: actions/setup-node@v1
1616
with:
17-
node-version: 12
17+
node-version: 14
1818
registry-url: https://registry.npmjs.org/
1919
- name: Install dependencies
2020
run: yarn install

.github/workflows/tests.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ jobs:
1515
strategy:
1616
fail-fast: false
1717
matrix:
18-
node: [ '12', '14' ]
18+
node: [ '14', '16' ]
1919
name: Tests (Node.js ${{ matrix.node }})
2020
steps:
2121
- uses: actions/checkout@v2

CONTRIBUTING.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ You can check out the longer, more complete guideline documentation [here](https
4343

4444
To run this project, you will need:
4545

46-
- Node.js >= v12 and node < 15
46+
- Node.js >= 14 and node <= 16
4747
- Yarn
4848

4949
### Setup <!-- omit in TOC -->

bors.toml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
status = [
22
'linter-check',
3-
'Tests (Node.js 12)',
4-
'Tests (Node.js 14)'
3+
'Tests (Node.js 14)',
4+
'Tests (Node.js 16)'
55
]
66
# 1 hour timeout
77
timeout-sec = 3600

playground/package.json

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,5 +12,8 @@
1212
"meilisearch": "^0.27.0",
1313
"vuepress": "^1.4.1",
1414
"vuepress-theme-default-prefers-color-scheme": "^2.0.0"
15+
},
16+
"engines": {
17+
"node": ">=14 <=16"
1518
}
1619
}

tests/MeiliSearchBoxTest.js

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,8 @@ describe('MeiliSearchBox', () => {
88
wrapper = shallowMount(MeiliSearchBox, {
99
mocks: {
1010
$site: { themeConfig: {} }
11-
}
11+
},
12+
attachTo: document.body
1213
})
1314
})
1415

@@ -17,7 +18,11 @@ describe('MeiliSearchBox', () => {
1718
'<form id="search-form" role="search" class="meilisearch-search-wrapper search-box theme-light">'
1819
)
1920
expect(wrapper.html()).toContain(
20-
'<input id="meilisearch-search-input" class="search-query" placeholder="">'
21+
'<input id="meilisearch-search-input" class="search-query dsb-input" placeholder="" autocomplete="off" spellcheck="false" role="combobox" aria-autocomplete="list" aria-expanded="false" aria-label="search input" aria-owns="meilisearch-autocomplete-listbox-0" style="vertical-align: top;" dir="auto">'
2122
)
2223
})
24+
25+
afterEach(() => {
26+
wrapper.destroy()
27+
})
2328
})

0 commit comments

Comments
 (0)