glob: Fix GLOBIGNORE test for bash 4.4, add note

Bash 4.4 was released last night, and apparently the `GLOBIGNORE`
behavior changed in a fashion that broke the 'glob/main: recursively
discover files' case. Specifically, a pattern with a leading `*` doesn't
seem to match arbitrarily deep subdirectory prefixes anymore. Expanding
the `--ignore` argument to be more specific fixes the test for bash 4.4
and still works for previous versions.

Author: mbland

libexec/glob

@@ -39,6 +39,11 @@
 # NOTE: If a <glob> produces errors, or generally doesn't do as you expect,
 # you may need to include it in quotes so it isn't expanded by the shell
 # _before_ executing the {{cmd}} command.
+#
+# NOTE FOR BASH 4.4: Something changed with GLOBIGNORE behavior such that
+# `GLOBIGNORE` patterns of the form `*ignore-me` no longer match arbitrarily
+# deep subdirectory prefixes. Consequently, you may need to use multiple
+# `--ignore` patterns to achieve the same effect.
 
 _@go.glob_impl() {
   local pattern="$1"

tests/glob/main.bats

@@ -201,7 +201,12 @@ teardown() {
     "quux/xyzzy"
     "quux/xyzzy/frotz")
 
-  run ./go glob --ignore '*ignore-me*' --trim "$TESTS_DIR" '.bats'
+  # The `--ignore` pattern below was previously '*ignore-me*'. This worked on
+  # bash 3.2, 4.2, and 4.3. However, something changed in bash 4.4 that caused
+  # that pattern not to work at all anymore. The current pattern works for all
+  # bash versions.
+  run ./go glob --ignore 'ignore-me:*/ignore-me:foo/bar/baz/ignore-me*' \
+    --trim "$TESTS_DIR" '.bats'
   local IFS=$'\n'
   assert_success "${expected[*]}"
 }