lib/log: Improve @go.log_command line formatting

It occurred to me that `@go.log_command` should not try to only convert
unexpanded formatting code sequences if they exist in the output, but
should strip them out entirely whether they're expanded or not.

Author: mbland

lib/log

@@ -460,6 +460,7 @@ readonly __GO_LOG_COMMAND_EXIT_PATTERN='^@go.log_command (exit|fatal):([0-9]+)$'
   local __go_log_command_args=("$@")
   local cmd_string="${__go_log_command_args[*]}"
   local line
+  local stripped_line
   local exit_state
   local exit_status=1
 
@@ -482,6 +483,7 @@ readonly __GO_LOG_COMMAND_EXIT_PATTERN='^@go.log_command (exit|fatal):([0-9]+)$'
 
   while IFS= read -r line; do
     line="${line%$'\r'}"
+    stripped_line=''
 
     if [[ "$line" =~ $__GO_LOG_COMMAND_EXIT_PATTERN ]]; then
       # If the line immediately previous was fatal, keep the fatal state.
@@ -497,9 +499,12 @@ readonly __GO_LOG_COMMAND_EXIT_PATTERN='^@go.log_command (exit|fatal):([0-9]+)$'
 
     for fd in "${__go_log_level_file_descriptors[@]}"; do
       if [[ -t "$fd" || -n "$_GO_LOG_FORMATTING" ]]; then
-        printf '%b\n' "$line" >&"$fd"
-      else
         printf '%s\n' "$line" >&"$fd"
+      else
+        if [[ -z "$stripped_line" ]]; then
+          @go.strip_formatting_codes "$line" stripped_line
+        fi
+        printf '%s\n' "$stripped_line" >&"$fd"
       fi
     done
   done < <(_@go.log_command_invoke)

tests/log/log-command.bats

@@ -101,15 +101,15 @@ teardown() {
 @test "$SUITE: log single failing command to standard error" {
   run_log_script \
       'function failing_function() {' \
-      '  printf "%s\n" "\e[1m$*\e[0m" >&2' \
+      '  printf "%b\n" "\e[1m$*\e[0m" >&2' \
       '  exit 127' \
       '}' \
       '@go.log_command failing_function foo bar baz'
 
   assert_failure
   assert_log_equals \
     RUN 'failing_function foo bar baz' \
-    '\e[1mfoo bar baz\e[0m' \
+    'foo bar baz' \
     ERROR 'failing_function foo bar baz (exit status 127)'
   assert_log_file_equals "$TEST_LOG_FILE" "${lines[@]}"
 }
@@ -120,7 +120,7 @@ teardown() {
 
   _GO_LOG_FORMATTING='true' run_log_script \
       'function failing_function() {' \
-      '  printf "%s\n" "\e[1m$*\e[0m" >&2' \
+      '  printf "%b\n" "\e[1m$*\e[0m" >&2' \
       '  exit 127' \
       '}' \
       '@go.log_command failing_function foo bar baz'