From cc68330d00469cd6401336116238fe100732b5ac Mon Sep 17 00:00:00 2001
From: Jon Stevens <latchkey@gmail.com>
Date: Tue, 29 Nov 2011 21:54:38 -0800
Subject: [PATCH 1/9] consistently use single quotes

---
 src/form2js.js | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/form2js.js b/src/form2js.js
index c41106d..0d88b6b 100644
--- a/src/form2js.js
+++ b/src/form2js.js
@@ -52,7 +52,7 @@ var form2js = (function()
 			i = 0;
 
 		/* If rootNode is array - combine values */
-		if (rootNode.constructor == Array || (typeof NodeList != "undefined" && rootNode.constructor == NodeList))
+		if (rootNode.constructor == Array || (typeof NodeList != 'undefined' && rootNode.constructor == NodeList))
 		{
 			while(currNode = rootNode[i++])
 			{
@@ -274,8 +274,8 @@ var form2js = (function()
 				switch (fieldNode.type.toLowerCase()) {
 					case 'radio':
 					case 'checkbox':
-                        if (fieldNode.checked && fieldNode.value === "true") return true;
-                        if (!fieldNode.checked && fieldNode.value === "true") return false;
+                        if (fieldNode.checked && fieldNode.value === 'true') return true;
+                        if (!fieldNode.checked && fieldNode.value === 'true') return false;
 						if (fieldNode.checked) return fieldNode.value;
 						break;
 
@@ -312,7 +312,7 @@ var form2js = (function()
 
 		if (!multiple) return selectNode.value;
 
-		for (options = selectNode.getElementsByTagName("option"), i = 0, l = options.length; i < l; i++)
+		for (options = selectNode.getElementsByTagName('option'), i = 0, l = options.length; i < l; i++)
 		{
 			if (options[i].selected) result.push(options[i].value);
 		}

From bc97b68a844772b3ec7cce976f3aa8adb56680e8 Mon Sep 17 00:00:00 2001
From: Jon Stevens <latchkey@gmail.com>
Date: Tue, 29 Nov 2011 22:09:02 -0800
Subject: [PATCH 2/9] example of broken useIdIfEmptyName

---
 example/js2form.example.html | 54 +++++++++++++++++++++++++++++++++++-
 1 file changed, 53 insertions(+), 1 deletion(-)

diff --git a/example/js2form.example.html b/example/js2form.example.html
index 27e03b8..2aba5f5 100644
--- a/example/js2form.example.html
+++ b/example/js2form.example.html
@@ -79,13 +79,65 @@
 					<label><input type="radio" name="foo.radio" value="4"> 4</label>
 				</dd>
 			</dl>
+
+
+			<table>
+			<tbody>
+			<tr>
+				<th>Phone</th>
+				<td><input type="text" id="phone" name="phone" /></td>
+			</tr>
+			<tr>
+				<th>Address</th>
+				<td>
+					<table id="addressInfo" class="condensed-table">
+						<tr>
+							<th>Street 1</th>
+							<td><input type="text" id="address.street1" name="address.street1" /></td>
+						</tr>
+						<tr>
+							<th>Street 2</th>
+							<td><input type="text" id="address.street2" name="address.street2" /></td>
+						</tr>
+						<tr>
+							<th>City</th>
+							<td><input type="text" id="address.city" name="address.city" /></td>
+						</tr>
+						<tr>
+							<th>State</th>
+							<td><input type="text" id="address.state" name="address.state" /></td>
+						</tr>
+						<tr>
+							<th>Zip</th>
+							<td><input type="text" id="address.zip" name="address.zip" /></td>
+						</tr>
+						<tr>
+							<th>Country</th>
+							<td><input type="text" id="address.country" name="address.country" /></td>
+						</tr>
+					</table>
+				</td>
+			</tr>
+			</tbody>
+			</table>
+
 			<button type="button" onclick="getJson()">Get JSON</button>
 			<button type="reset">Reset form</button>
+
 		</form>
 
 		<div>
 			<textarea id="src" cols="70" rows="20">
 {
+	"phone":"444-444-4444",
+	"address":{
+		"street1": "12345",
+		"street2": "main st",
+		"city": "SF",
+		"state": "CA",
+		"zip": "94444",
+		"country": "USA"
+	},
 	"foo":{
 		"radio":"3",
 		"name":{
@@ -131,7 +183,7 @@
 			{
 				var data = document.getElementById('src').value;
 				data = JSON.parse(data);
-				js2form(document.getElementById('testForm'), data);
+				js2form(document.getElementById('testForm'), data, '.', null, false);
 			}
 		</script>
 	</body>

From da898773336a4722e982198a54bb4474e309e7e1 Mon Sep 17 00:00:00 2001
From: Jon Stevens <latchkey@gmail.com>
Date: Tue, 29 Nov 2011 22:18:49 -0800
Subject: [PATCH 3/9] field should have been true.

---
 example/js2form.example.html | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/example/js2form.example.html b/example/js2form.example.html
index 2aba5f5..31e1664 100644
--- a/example/js2form.example.html
+++ b/example/js2form.example.html
@@ -183,7 +183,7 @@
 			{
 				var data = document.getElementById('src').value;
 				data = JSON.parse(data);
-				js2form(document.getElementById('testForm'), data, '.', null, false);
+				js2form(document.getElementById('testForm'), data, '.', null, true);
 			}
 		</script>
 	</body>

From 97f8636f323bd3b8c0752a3a92b8a458749f6e01 Mon Sep 17 00:00:00 2001
From: Jon Stevens <latchkey@gmail.com>
Date: Fri, 2 Dec 2011 00:28:00 -0800
Subject: [PATCH 4/9] check for value on for checkboxes

---
 src/form2js.js | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/form2js.js b/src/form2js.js
index 0d88b6b..cec0fa9 100644
--- a/src/form2js.js
+++ b/src/form2js.js
@@ -274,8 +274,8 @@ var form2js = (function()
 				switch (fieldNode.type.toLowerCase()) {
 					case 'radio':
 					case 'checkbox':
-                        if (fieldNode.checked && fieldNode.value === 'true') return true;
-                        if (!fieldNode.checked && fieldNode.value === 'true') return false;
+                        if (fieldNode.checked && fieldNode.value === 'true' || fieldNode.value === 'on') return true;
+                        if (!fieldNode.checked && fieldNode.value === 'true' || fieldNode.value === 'on') return false;
 						if (fieldNode.checked) return fieldNode.value;
 						break;
 

From 64c1ab6e0bd81c323f277246be220a1709a6bb93 Mon Sep 17 00:00:00 2001
From: Jon Stevens <latchkey@gmail.com>
Date: Fri, 2 Dec 2011 00:55:17 -0800
Subject: [PATCH 5/9] check for various default values for a checkbox.

---
 src/js2form.js | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/js2form.js b/src/js2form.js
index 78f4fd5..4403408 100644
--- a/src/js2form.js
+++ b/src/js2form.js
@@ -79,7 +79,8 @@ var js2form = (function()
 		{
 			for(i = 0; i < field.length; i++)
 			{
-				if (field[i].value == value) field[i].checked = true;
+				if (field[i].value == 'on' || field[i].value == 'true' || 
+					field[i].value == value) field[i].checked = true;
 			}
 		}
 		else if (_inputOrTextareaRegexp.test(field.nodeName))

From 06c9d6f4df4f387d284152c62224bf08df53796d Mon Sep 17 00:00:00 2001
From: Jon Stevens <latchkey@gmail.com>
Date: Fri, 2 Dec 2011 19:56:56 -0800
Subject: [PATCH 6/9] fix the population of checkboxes

---
 src/js2form.js | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/src/js2form.js b/src/js2form.js
index 4403408..14c028e 100644
--- a/src/js2form.js
+++ b/src/js2form.js
@@ -77,10 +77,12 @@ var js2form = (function()
 
 		if (field instanceof Array)
 		{
-			for(i = 0; i < field.length; i++)
+			for (i = 0; i < field.length; i++)
 			{
-				if (field[i].value == 'on' || field[i].value == 'true' || 
-					field[i].value == value) field[i].checked = true;
+				if (value == 'on' || value == 'true' || value == '1')
+					field[i].checked = true;
+				else
+					field[i].checked = false
 			}
 		}
 		else if (_inputOrTextareaRegexp.test(field.nodeName))

From dbbab506f9f6b5d4578a8dee4c5f510594e793cc Mon Sep 17 00:00:00 2001
From: Jon Stevens <latchkey@gmail.com>
Date: Fri, 2 Dec 2011 20:00:17 -0800
Subject: [PATCH 7/9] only set value if value is not null

---
 src/js2form.js | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/js2form.js b/src/js2form.js
index 14c028e..3f0e163 100644
--- a/src/js2form.js
+++ b/src/js2form.js
@@ -87,7 +87,8 @@ var js2form = (function()
 		}
 		else if (_inputOrTextareaRegexp.test(field.nodeName))
 		{
-			field.value = value;
+			if (value)
+				field.value = value;
 		}
 		else if (/SELECT/i.test(field.nodeName))
 		{

From 01631d841c534969d5db1b514f8da2e437f8f8b5 Mon Sep 17 00:00:00 2001
From: Mike McKay <mikeymckay@gmail.com>
Date: Fri, 16 Dec 2011 00:14:35 -0500
Subject: [PATCH 8/9] Fixes 28 (https://github.com/maxatwork/form2js/issues/28)

---
 src/form2js.js | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/src/form2js.js b/src/form2js.js
index c41106d..fe9c37d 100644
--- a/src/form2js.js
+++ b/src/form2js.js
@@ -242,8 +242,11 @@ var form2js = (function()
             result = [callbackResult];
         }
         else if (fieldName != '' && node.nodeName.match(/INPUT|TEXTAREA/i)) {
-            fieldValue = getFieldValue(node);
-			result = [ { name: fieldName, value: fieldValue} ];
+            fieldValue = getFieldValue(node);   
+	    if(node.type == 'radio' && fieldValue == null)
+                result = [];
+            else
+                result = [ { name: fieldName, value: fieldValue} ];
         }
         else if (fieldName != '' && node.nodeName.match(/SELECT/i)) {
 	        fieldValue = getFieldValue(node);

From 796c15b108f941075a704bd074702c6c210eccc6 Mon Sep 17 00:00:00 2001
From: Jon Stevens <latchkey@gmail.com>
Date: Thu, 15 Dec 2011 23:17:16 -0800
Subject: [PATCH 9/9] merged radio button fixes from
 https://github.com/maxatwork/form2js/pull/29

---
 src/form2js.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/form2js.js b/src/form2js.js
index 7e694dc..4fd8e0c 100644
--- a/src/form2js.js
+++ b/src/form2js.js
@@ -243,7 +243,7 @@ var form2js = (function()
         }
         else if (fieldName != '' && node.nodeName.match(/INPUT|TEXTAREA/i)) {
             fieldValue = getFieldValue(node);   
-	    if(node.type == 'radio' && fieldValue == null)
+	        if (fieldValue == null && node.type == 'radio')
                 result = [];
             else
                 result = [ { name: fieldName, value: fieldValue} ];