Add Preliminary Support for Java Records (#8)

* Switch to using Spring's BeanUtils for feteching introspection data

* Use Java 17 as the required compiler version.

* Set the bytecode to Java 8 for main compiler output.
* Use Java 17 bytecode for integration tests.

* Update README with build updates

* Preliminary support for Java records.

This support depends on the constructor binding support found in Spring MVC and WebFlux already. Nested binding is not supported in this iteration.

* Assert not null.

* Get branch up to date with latest from main.

* Update javadoc.

* Get rid of kotlin compile warning.

* Add webmvc integration tests for java record support.

* Add webflux integration tests for java record support.

* Update Spring dependency versions.

* Update notes.

* Don't start a daemon.

* Use direct interface for constant.

* Try to use aggregated report for coverage.

* Fix filename.

* Skip install phase.

Author: mattbertolini

.travis.yml

@@ -1,4 +1,5 @@
 language: java
+install: skip
 
 addons:
   sonarcloud:
@@ -8,12 +9,6 @@ addons:
 
 jobs:
   include:
-    - name: OpenJDK 8
-      jdk: openjdk8
-      script: ./gradlew jacocoTestReport check
-    - name: OpenJDK 11
-      jdk: openjdk11
-      script: ./gradlew jacocoTestReport sonarqube
     - name: OpenJDK 17
       jdk: openjdk17
-      script: ./gradlew jacocoTestReport check
+      script: ./gradlew --no-daemon jacocoTestReport testCodeCoverageReport sonarqube

README.md

@@ -161,6 +161,10 @@ public BinderConfiguration binderConfiguration() {
 
 ## Build
 
+### Build Requirements
+
+* Java 17 or above to build. The release jars are compiled to Java 8 bytecode. Integration tests are compiled to Java 17 bytecode.
+
 To build:
 
 ```shell

RELEASE_NOTES.md

@@ -1,5 +1,12 @@
 # Release Notes
 
+## 0.5.0 
+IN PROGRESS
+
+- Added preliminary support for Java records.
+- JDK 17 is now required to build this project. The production artifacts are still compiled to Java 1.8 bytecode.
+- Upgraded to equals verifier 3.10
+
 ## 0.4.0
 Released 2021-06-20
 

build.gradle.kts

@@ -6,16 +6,16 @@ plugins {
     id("org.sonarqube") version "3.3"
 }
 
-val springVersion = "5.3.8"
-val springBootVersion = "2.4.7"
+val springVersion = "5.3.13"
+val springBootVersion = "2.4.13"
 
 val rootJacocoDir by extra("${rootProject.buildDir}/reports/jacoco/testCodeCoverageReport")
-val reportXmlFile by extra("$rootJacocoDir/jacocoTestReport.xml")
+val reportXmlFile by extra("$rootJacocoDir/testCodeCoverageReport.xml")
 
 val javadocLinks = arrayOf(
     "https://docs.oracle.com/javase/8/docs/api/",
     "https://docs.oracle.com/javaee/7/api/",
-    "https://docs.spring.io/spring/docs/$springVersion/javadoc-api/",
+    "https://docs.spring.io/spring-framework/docs/$springVersion/javadoc-api/",
     "https://docs.spring.io/spring-boot/docs/$springBootVersion/api/"
 )
 
@@ -36,10 +36,14 @@ subprojects {
 
     java {
         toolchain {
-            languageVersion.set(JavaLanguageVersion.of(8))
+            languageVersion.set(JavaLanguageVersion.of(17))
         }
     }
 
+    tasks.compileJava {
+        options.release.set(8)
+    }
+
 //    sourceCompatibility = 1.8
 
     dependencies {
@@ -55,7 +59,7 @@ subprojects {
         // Test
         implementation(platform("org.junit:junit-bom:5.6.1"))
         implementation(platform("org.assertj:assertj-core:3.15.0"))
-        implementation(platform("nl.jqno.equalsverifier:equalsverifier:3.1.13"))
+        implementation(platform("nl.jqno.equalsverifier:equalsverifier:3.10"))
         implementation(platform("org.mockito:mockito-core:3.3.3"))
     }
 
@@ -121,6 +125,6 @@ dependencies {
 sonarqube {
     properties {
         property("sonar.projectKey", "mattbertolini_spring-annotated-web-data-binder")
-//        property "sonar.coverage.jacoco.xmlReportPaths", reportXmlFile
+        property("sonar.coverage.jacoco.xmlReportPaths", reportXmlFile)
     }
 }

buildSrc/build.gradle.kts

@@ -2,6 +2,12 @@ plugins {
     `kotlin-dsl`
 }
 
+tasks.withType<org.jetbrains.kotlin.gradle.tasks.KotlinCompile> {
+    kotlinOptions {
+        jvmTarget = "1.8"
+    }
+}
+
 repositories {
     mavenCentral()
 }

integration-tests/build.gradle.kts

@@ -18,6 +18,10 @@ dependencies {
     testCompileOnly("org.hamcrest:hamcrest") // Version defined in Spring BOM file
 }
 
+tasks.compileJava {
+    options.release.set(17)
+}
+
 tasks.jacocoTestReport {
     reports {
         html.required.set(false)

integration-tests/src/test/java/com/mattbertolini/spring/test/web/bind/CookieParameterController.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2019-2020 the original author or authors.
+ * Copyright 2019-2022 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -16,6 +16,7 @@
 
 package com.mattbertolini.spring.test.web.bind;
 
+import com.mattbertolini.spring.test.web.bind.records.CookieParameterRecord;
 import com.mattbertolini.spring.web.bind.annotation.BeanParameter;
 import org.springframework.http.MediaType;
 import org.springframework.validation.BindingResult;
@@ -63,4 +64,9 @@ public String validatedWithBindingResult(@Valid @BeanParameter CookieParameterBe
     public String nestedBean(@BeanParameter CookieParameterBean cookieParameterBean) {
         return cookieParameterBean.getNestedBean().getCookieValue();
     }
+
+    @GetMapping(value = "/record", produces = MediaType.TEXT_PLAIN_VALUE)
+    public String javaRecord(@BeanParameter CookieParameterRecord cookieParameterRecord) {
+        return cookieParameterRecord.annotated();
+    }
 }

integration-tests/src/test/java/com/mattbertolini/spring/test/web/bind/FormParameterController.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2019-2021 the original author or authors.
+ * Copyright 2019-2022 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -16,6 +16,7 @@
 
 package com.mattbertolini.spring.test.web.bind;
 
+import com.mattbertolini.spring.test.web.bind.records.FormParameterRecord;
 import com.mattbertolini.spring.web.bind.annotation.BeanParameter;
 import org.springframework.core.io.buffer.DataBuffer;
 import org.springframework.core.io.buffer.DataBufferUtils;
@@ -164,4 +165,9 @@ public String webFluxFilePart(@BeanParameter FormParameterBean.WebfluxMultipartB
     public String nestedBeanParameter(@BeanParameter FormParameterBean formParameterBean) {
         return formParameterBean.getNestedBean().getFormData();
     }
+
+    @PostMapping(value = "/record", produces = MediaType.TEXT_PLAIN_VALUE)
+    public String javaRecord(@BeanParameter FormParameterRecord formParameterRecord) {
+        return formParameterRecord.annotated();
+    }
 }

integration-tests/src/test/java/com/mattbertolini/spring/test/web/bind/HeaderParameterController.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2019-2020 the original author or authors.
+ * Copyright 2019-2022 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -16,6 +16,7 @@
 
 package com.mattbertolini.spring.test.web.bind;
 
+import com.mattbertolini.spring.test.web.bind.records.HeaderParameterRecord;
 import com.mattbertolini.spring.web.bind.annotation.BeanParameter;
 import org.springframework.http.HttpHeaders;
 import org.springframework.http.MediaType;
@@ -84,4 +85,9 @@ public String validatedWithBindingResult(@Valid @BeanParameter HeaderParameterBe
     public String nestedBean(@BeanParameter HeaderParameterBean headerParameterBean) {
         return headerParameterBean.getNestedBean().getHeaderValue();
     }
+
+    @GetMapping(value = "/record", produces = MediaType.TEXT_PLAIN_VALUE)
+    public String javaRecord(@BeanParameter HeaderParameterRecord headerParameterRecord) {
+        return headerParameterRecord.annotated();
+    }
 }

integration-tests/src/test/java/com/mattbertolini/spring/test/web/bind/PathParameterController.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2019-2020 the original author or authors.
+ * Copyright 2019-2022 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -16,6 +16,7 @@
 
 package com.mattbertolini.spring.test.web.bind;
 
+import com.mattbertolini.spring.test.web.bind.records.PathParameterRecord;
 import com.mattbertolini.spring.web.bind.annotation.BeanParameter;
 import org.springframework.http.MediaType;
 import org.springframework.validation.BindingResult;
@@ -71,4 +72,9 @@ public String validatedWithBindingResult(@Valid @BeanParameter PathParameterBean
     public String nestedBean(@BeanParameter PathParameterBean pathParameterBean) {
         return pathParameterBean.getNestedBean().getPathVariable();
     }
+
+    @GetMapping(value = "/record/{annotated_field}", produces = MediaType.TEXT_PLAIN_VALUE)
+    public String javaRecord(@BeanParameter PathParameterRecord pathParameterRecord) {
+        return pathParameterRecord.annotated();
+    }
 }