Remove sonar code smells.

Author: mattbertolini

spring-annotated-data-binder-core/src/test/java/com/mattbertolini/spring/web/bind/introspect/DefaultAnnotatedRequestBeanIntrospectorTest.java

@@ -51,7 +51,7 @@ void returnsResolversForType() {
         FakeResolver resolver = new FakeResolver(RequestParameter.class);
         registry.addResolver(resolver);
         Collection<ResolvedPropertyData> resolvers = introspector.getResolversFor(SimpleType.class);
-        assertThat(resolvers.size()).isEqualTo(1);
+        assertThat(resolvers).hasSize(1);
         ResolvedPropertyData data = resolvers.iterator().next();
         assertThat(data.getPropertyName()).isEqualTo("data");
     }
@@ -61,7 +61,7 @@ void returnsResolversUsingNestedTypes() {
         FakeResolver resolver = new FakeResolver(RequestParameter.class);
         registry.addResolver(resolver);
         Collection<ResolvedPropertyData> resolvers = introspector.getResolversFor(OuterBean.class);
-        assertThat(resolvers.size()).isEqualTo(1);
+        assertThat(resolvers).hasSize(1);
         ResolvedPropertyData data = resolvers.iterator().next();
         assertThat(data.getPropertyName()).isEqualTo("innerBean.inner");
     }

spring-webflux-annotated-data-binder/src/test/java/com/mattbertolini/spring/web/reactive/bind/PropertyResolverRegistryTest.java

@@ -23,25 +23,25 @@ void setUp() {
 
     @Test
     void addsResolversFromSet() {
-        assertThat(registry.getPropertyResolvers().size()).isZero();
+        assertThat(registry.getPropertyResolvers()).isEmpty();
         registry.addResolvers(Collections.singleton(new FakeResolver()));
-        assertThat(registry.getPropertyResolvers().size()).isEqualTo(1);
+        assertThat(registry.getPropertyResolvers()).hasSize(1);
     }
 
     @Test
     void addsSingleResolver() {
-        assertThat(registry.getPropertyResolvers().size()).isZero();
+        assertThat(registry.getPropertyResolvers()).isEmpty();
         registry.addResolver(new FakeResolver());
-        assertThat(registry.getPropertyResolvers().size()).isEqualTo(1);
+        assertThat(registry.getPropertyResolvers()).hasSize(1);
     }
 
     @Test
     void addsResolversFromRegistry() {
         PropertyResolverRegistry anotherRegistry = new PropertyResolverRegistry();
         anotherRegistry.addResolver(new FakeResolver());
-        assertThat(registry.getPropertyResolvers().size()).isZero();
+        assertThat(registry.getPropertyResolvers()).isEmpty();
         registry.addResolvers(anotherRegistry);
-        assertThat(registry.getPropertyResolvers().size()).isEqualTo(1);
+        assertThat(registry.getPropertyResolvers()).hasSize(1);
     }
 
     private static class FakeResolver implements RequestPropertyResolver {

spring-webmvc-annotated-data-binder/src/test/java/com/mattbertolini/spring/web/servlet/mvc/bind/PropertyResolverRegistryTest.java

@@ -22,25 +22,25 @@ void setUp() {
 
     @Test
     void addsResolversFromSet() {
-        assertThat(registry.getPropertyResolvers().size()).isZero();
+        assertThat(registry.getPropertyResolvers()).isEmpty();
         registry.addResolvers(Collections.singleton(new FakeResolver()));
-        assertThat(registry.getPropertyResolvers().size()).isEqualTo(1);
+        assertThat(registry.getPropertyResolvers()).hasSize(1);
     }
 
     @Test
     void addsSingleResolver() {
-        assertThat(registry.getPropertyResolvers().size()).isZero();
+        assertThat(registry.getPropertyResolvers()).isEmpty();
         registry.addResolver(new FakeResolver());
-        assertThat(registry.getPropertyResolvers().size()).isEqualTo(1);
+        assertThat(registry.getPropertyResolvers()).hasSize(1);
     }
 
     @Test
     void addsResolversFromRegistry() {
         PropertyResolverRegistry anotherRegistry = new PropertyResolverRegistry();
         anotherRegistry.addResolver(new FakeResolver());
-        assertThat(registry.getPropertyResolvers().size()).isZero();
+        assertThat(registry.getPropertyResolvers()).isEmpty();
         registry.addResolvers(anotherRegistry);
-        assertThat(registry.getPropertyResolvers().size()).isEqualTo(1);
+        assertThat(registry.getPropertyResolvers()).hasSize(1);
     }
 
     private static class FakeResolver implements RequestPropertyResolver {