From 1b7319e9e64f05a973ac4b9319eea21867c74ea7 Mon Sep 17 00:00:00 2001 From: Sam Eagen Date: Wed, 25 Mar 2026 11:45:32 -0400 Subject: [PATCH 1/2] Add warning for parallel builds --- .../+buildtool/+plugins/OpenTelemetryPlugin.m | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/instrumentation/buildtool/+matlab/+buildtool/+plugins/OpenTelemetryPlugin.m b/instrumentation/buildtool/+matlab/+buildtool/+plugins/OpenTelemetryPlugin.m index f0a3a85..2c0043e 100644 --- a/instrumentation/buildtool/+matlab/+buildtool/+plugins/OpenTelemetryPlugin.m +++ b/instrumentation/buildtool/+matlab/+buildtool/+plugins/OpenTelemetryPlugin.m @@ -4,6 +4,17 @@ methods(Access = protected) function runBuild(plugin, pluginData) + % Warn users that tasks on workers will not emit telemetry data + % if a pool is open. + % + % Imperfect detection of parallel builds but + % the impact of a false positive is very low + p = gcp("nocreate"); + if ~isempty(p) + warning("opentelemetry:buildtool:OpenTelemetryPlugin:NoParallelEmit", ... + "Tasks run on parallel workers will not emit telemetry data"); + end + % Configure by attaching to span if passed in via environment % variable, and propagating baggage configureOTel(); @@ -56,10 +67,6 @@ function runBuild(plugin, pluginData) end function runTask(plugin, pluginData) - % TODO: - % - buildtool.task.outputs - % - buildtool.task.inputs - % Definitions task = pluginData.TaskGraph.Tasks; taskName = pluginData.Name; From 1add83956b3bd6d72d8cf87afa5f105943cfed76 Mon Sep 17 00:00:00 2001 From: sameagen-MW <122639681+sameagen-MW@users.noreply.github.com> Date: Wed, 25 Mar 2026 14:03:16 -0400 Subject: [PATCH 2/2] Update warning message for parallel builds --- .../+matlab/+buildtool/+plugins/OpenTelemetryPlugin.m | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/instrumentation/buildtool/+matlab/+buildtool/+plugins/OpenTelemetryPlugin.m b/instrumentation/buildtool/+matlab/+buildtool/+plugins/OpenTelemetryPlugin.m index 2c0043e..30730b8 100644 --- a/instrumentation/buildtool/+matlab/+buildtool/+plugins/OpenTelemetryPlugin.m +++ b/instrumentation/buildtool/+matlab/+buildtool/+plugins/OpenTelemetryPlugin.m @@ -12,7 +12,7 @@ function runBuild(plugin, pluginData) p = gcp("nocreate"); if ~isempty(p) warning("opentelemetry:buildtool:OpenTelemetryPlugin:NoParallelEmit", ... - "Tasks run on parallel workers will not emit telemetry data"); + "Tasks executed on parallel workers do not emit telemetry data."); end % Configure by attaching to span if passed in via environment @@ -194,4 +194,4 @@ function cleanupOTel(span) otellp = opentelemetry.logs.Provider.getLoggerProvider; opentelemetry.sdk.common.Cleanup.forceFlush(otellp, timeout); opentelemetry.sdk.common.Cleanup.shutdown(otellp); -end \ No newline at end of file +end