Skip to content
This repository was archived by the owner on Oct 26, 2024. It is now read-only.

Commit b76e51a

Browse files
committed
Added coverage for ConfigEnv::__construct() and fixed weak comparisons
1 parent 004faba commit b76e51a

File tree

3 files changed

+3
-2
lines changed

3 files changed

+3
-2
lines changed

Config/ConfigAbstract.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ public function readConfig($file)
6868
);
6969
}
7070

71-
return Yaml::parse($file);
71+
return (array)Yaml::parse($file);
7272
}
7373

7474
/**

Tests/Config/ConfigEnvTest.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ class ConfigEnvTest extends \PHPUnit_Framework_TestCase
2323
{
2424
/**
2525
* @covers \Asm\Config\ConfigEnv::mergeEnvironments
26+
* @covers \Asm\Config\ConfigEnv::__construct
2627
* @return \Asm\Config\ConfigInterface
2728
*/
2829
public function testFactoryProd()

Timer/Timer.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,7 @@ private function checkHoliday($date = null)
170170
$startTime = array('00', '00', '00');
171171
$endTime = array('23', '59', '59');
172172

173-
if (isset($this->currentConf['holiday']['interval'])) {
173+
if (true === isset($this->currentConf['holiday']['interval'])) {
174174
$startTime = explode(':', $this->currentConf['holiday']['interval'][0]);
175175
$endTime = explode(':', $this->currentConf['holiday']['interval'][1]);
176176
}

0 commit comments

Comments
 (0)