Add loading indicator and optimize heatmap query performance #305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add loading spinner overlay when heatmap is enabled and data is loading - Combine 3 separate database queries into a single optimized query using LEFT JOIN with pre-aggregated subqueries for user ascents/attempts - Add database indexes optimized for heatmap aggregation on hold_id - Add indexes on ascents and bids tables for user-specific queries
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
- Add enabled parameter to useHeatmapData hook to defer fetching - Only fetch heatmap data when user clicks "Show Heatmap" button - Move showHeatmap state declaration before hook call
The loading state is now computed as enabled && (!hasFetched || isFetching) which ensures the spinner shows immediately when the user clicks "Show Heatmap" rather than waiting for useEffect to run after the render.
The raw SQL approach broke because whereConditions from createClimbFilters uses Drizzle ORM table references that don't match raw SQL aliases. Reverted to original Drizzle ORM query while keeping the optimization of running user ascents/attempts queries in parallel with Promise.all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LEFT JOIN with pre-aggregated subqueries for user ascents/attempts