Skip to content

Commit 20a4a13

Browse files
dhaeckerdhaecker
committed
PB-95: Video background for Row
- Changing to Play Only When Visible
1 parent 71010ff commit 20a4a13

File tree

5 files changed

+86
-86
lines changed

5 files changed

+86
-86
lines changed

‎app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/BackgroundConfigurationActionGroup.xml‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -206,7 +206,7 @@
206206
<argument name="overlayColor" defaultValue="{{PageBuilderVideoBackgroundOverlayColor_Empty.rgb}}" type="string"/>
207207
<argument name="infiniteLoop" defaultValue="PageBuilderVideoBackgroundInfiniteLoop_Enabled"/>
208208
<argument name="lazyLoad" defaultValue="PageBuilderVideoBackgroundLazyLoad_Enabled"/>
209-
<argument name="playOnlyVisible" defaultValue="PageBuilderVideoBackgroundPlayOnlyVisible_Enabled"/>
209+
<argument name="playOnlyWhenVisible" defaultValue="PageBuilderVideoBackgroundPlayOnlyWhenVisible_Enabled"/>
210210
<argument name="fallbackImage" defaultValue="PageBuilderVideoBackgroundFallbackImage_Empty"/>
211211
<argument name="index" defaultValue="1" type="string"/>
212212
</arguments>
@@ -249,7 +249,7 @@
249249
</assertEquals>
250250
<waitForElementVisible selector="{{section.videoBackgroundInfiniteLoop(index, infiniteLoop.value)}}" stepKey="waitForInfiniteLoop"/>
251251
<waitForElementVisible selector="{{section.videoBackgroundLazyLoad(index, lazyLoad.value)}}" stepKey="waitForLazyLoad"/>
252-
<waitForElementVisible selector="{{section.videoBackgroundPlayOnlyVisible(index, playOnlyVisible.value)}}" stepKey="waitForPlayOnlyVisible"/>
252+
<waitForElementVisible selector="{{section.videoBackgroundPlayOnlyWhenVisible(index, playOnlyWhenVisible.value)}}" stepKey="waitForPlayOnlyWhenVisible"/>
253253
<waitForElement selector="{{section.videoBackgroundFallbackImage(index)}}" stepKey="waitForFallbackImage"/>
254254
<waitForElementNotVisible selector="{{section.videoBackgroundFallbackImage(index)}}" stepKey="waitForFallbackImageNotVisible"/>
255255
<grabAttributeFrom selector="{{section.videoBackgroundFallbackImageSource(index, fallbackImage.fileName)}}" userInput="src" stepKey="fallbackImageSource"/>
@@ -351,7 +351,7 @@
351351
<argument name="videoUrl" defaultValue="PageBuilderVideoBackgroundUrl_Empty"/>
352352
<argument name="infiniteLoop" defaultValue="PageBuilderVideoBackgroundInfiniteLoop_Enabled"/>
353353
<argument name="lazyLoad" defaultValue="PageBuilderVideoBackgroundLazyLoad_Enabled"/>
354-
<argument name="playOnlyVisible" defaultValue="PageBuilderVideoBackgroundPlayOnlyVisible_Enabled"/>
354+
<argument name="playOnlyWhenVisible" defaultValue="PageBuilderVideoBackgroundPlayOnlyWhenVisible_Enabled"/>
355355
<argument name="index" defaultValue="1" type="string"/>
356356
</arguments>
357357
<waitForPageLoad stepKey="waitForPageLoad"/>
@@ -384,7 +384,7 @@
384384
<dontSeeElementInDOM selector="{{section.videoBackgroundOverlayElement(index)}}" stepKey="dontSeeOverlayColorInDOM"/>
385385
<waitForElementVisible selector="{{section.videoBackgroundInfiniteLoop(index, infiniteLoop.value)}}" stepKey="waitForInfiniteLoop"/>
386386
<waitForElementVisible selector="{{section.videoBackgroundLazyLoad(index, lazyLoad.value)}}" stepKey="waitForLazyLoad"/>
387-
<waitForElementVisible selector="{{section.videoBackgroundPlayOnlyVisible(index, playOnlyVisible.value)}}" stepKey="waitForPlayOnlyVisible"/>
387+
<waitForElementVisible selector="{{section.videoBackgroundPlayOnlyWhenVisible(index, playOnlyWhenVisible.value)}}" stepKey="waitForPlayOnlyWhenVisible"/>
388388
<waitForElement selector="{{section.videoBackgroundNoFallbackImage(index)}}" stepKey="waitForNoFallbackImage"/>
389389
<dontSeeElement selector="{{section.videoBackgroundNoFallbackImage(index)}}" stepKey="dontSeeFallbackImage"/>
390390
<dontSeeElementInDOM selector="{{section.videoBackgroundFallbackImage(index)}}" stepKey="dontSeeFallbackImageInDOM"/>

‎app/code/Magento/PageBuilder/Test/Mftf/Data/BackgroundFormData.xml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -559,14 +559,14 @@
559559
<data key="value">false</data>
560560
</entity>
561561
<!-- Video: Play Only When Visible -->
562-
<entity name="PageBuilderVideoBackgroundPlayOnlyVisible_Enabled" type="pagebuilder_video_background_play_only_visible">
562+
<entity name="PageBuilderVideoBackgroundPlayOnlyWhenVisible_Enabled" type="pagebuilder_video_background_play_only_visible">
563563
<data key="name">Play Only When Visible</data>
564564
<data key="section">background</data>
565565
<data key="fieldName">video_play_only_visible</data>
566566
<data key="value">true</data>
567567
<data key="helperText">Video will play only when it is visible on the screen.</data>
568568
</entity>
569-
<entity name="PageBuilderVideoBackgroundPlayOnlyVisible_Disabled" type="pagebuilder_video_background_play_only_visible">
569+
<entity name="PageBuilderVideoBackgroundPlayOnlyWhenVisible_Disabled" type="pagebuilder_video_background_play_only_visible">
570570
<data key="name">Play Only When Visible</data>
571571
<data key="section">background</data>
572572
<data key="fieldName">video_play_only_visible</data>

‎app/code/Magento/PageBuilder/Test/Mftf/Section/PageBuilderRowSection.xml‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@
6262
<element name="videoBackgroundOverlayElement" type="text" parameterized="true" selector="(//div[contains(@class,'pagebuilder-content-type') and contains(@class,'pagebuilder-row')])[{{rowIndex}}]//div[@data-element='video_overlay']"/>
6363
<element name="videoBackgroundInfiniteLoop" type="text" parameterized="true" selector="(//div[contains(@class,'pagebuilder-content-type') and contains(@class,'pagebuilder-row')])[{{rowIndex}}][@data-video-loop='{{infiniteLoopValue}}']"/>
6464
<element name="videoBackgroundLazyLoad" type="text" parameterized="true" selector="(//div[contains(@class,'pagebuilder-content-type') and contains(@class,'pagebuilder-row')])[{{rowIndex}}][@data-video-lazy-load='{{lazyLoadValue}}']"/>
65-
<element name="videoBackgroundPlayOnlyVisible" type="text" parameterized="true" selector="(//div[contains(@class,'pagebuilder-content-type') and contains(@class,'pagebuilder-row')])[{{rowIndex}}][@data-video-play-only-visible='{{playOnlyVisibleValue}}']"/>
65+
<element name="videoBackgroundPlayOnlyWhenVisible" type="text" parameterized="true" selector="(//div[contains(@class,'pagebuilder-content-type') and contains(@class,'pagebuilder-row')])[{{rowIndex}}][@data-video-play-only-visible='{{playOnlyWhenVisibleValue}}']"/>
6666
<element name="videoBackgroundFallbackImage" type="text" parameterized="true" selector="(//div[contains(@class,'pagebuilder-content-type') and contains(@class,'pagebuilder-row')])[{{rowIndex}}]//div[contains(@id,'jarallax-container')]//img"/>
6767
<element name="videoBackgroundFallbackImageSource" type="text" parameterized="true" selector="(//div[contains(@class,'pagebuilder-content-type') and contains(@class,'pagebuilder-row')])[{{rowIndex}}]//div[contains(@id,'jarallax-container')]//img[contains(@src,'{{fileName}}')]"/>
6868
<element name="videoBackgroundNoFallbackImage" type="text" parameterized="true" selector="(//div[contains(@class,'pagebuilder-content-type') and contains(@class,'pagebuilder-row')])[{{rowIndex}}]//div[contains(@id,'jarallax-container')]//div"/>
@@ -130,7 +130,7 @@
130130
<element name="videoBackgroundOverlayElement" type="text" parameterized="true" selector="(//div[@data-content-type='row'])[{{rowIndex}}]//div[@data-element='video_overlay']"/>
131131
<element name="videoBackgroundInfiniteLoop" type="text" parameterized="true" selector="(//div[@data-content-type='row'])[{{rowIndex}}]//div[@data-element='inner' and @data-video-loop='{{infiniteLoopValue}}']"/>
132132
<element name="videoBackgroundLazyLoad" type="text" parameterized="true" selector="(//div[@data-content-type='row'])[{{rowIndex}}]//div[@data-element='inner' and @data-video-lazy-load='{{lazyLoadValue}}']"/>
133-
<element name="videoBackgroundPlayOnlyVisible" type="text" parameterized="true" selector="(//div[@data-content-type='row'])[{{rowIndex}}]//div[@data-element='inner' and @data-video-play-only-visible='{{playOnlyVisibleValue}}']"/>
133+
<element name="videoBackgroundPlayOnlyWhenVisible" type="text" parameterized="true" selector="(//div[@data-content-type='row'])[{{rowIndex}}]//div[@data-element='inner' and @data-video-play-only-visible='{{playOnlyWhenVisibleValue}}']"/>
134134
<element name="videoBackgroundFallbackImage" type="text" parameterized="true" selector="(//div[@data-content-type='row'])[{{rowIndex}}]//div[contains(@id,'jarallax-container')]//img"/>
135135
<element name="videoBackgroundFallbackImageSource" type="text" parameterized="true" selector="(//div[@data-content-type='row'])[{{rowIndex}}]//div[contains(@id,'jarallax-container')]//img[contains(@src,'{{fileName}}')]"/>
136136
<element name="videoBackgroundNoFallbackImage" type="text" parameterized="true" selector="(//div[@data-content-type='row'])[{{rowIndex}}]//div[contains(@id,'jarallax-container')]//div"/>
@@ -179,7 +179,7 @@
179179
<element name="videoBackgroundOverlayElement" type="text" parameterized="true" selector="(//div[@data-content-type='row'])[{{rowIndex}}]//div[@data-element='video_overlay']"/>
180180
<element name="videoBackgroundInfiniteLoop" type="text" parameterized="true" selector="(//div[@data-content-type='row'])[{{rowIndex}}][@data-video-loop='{{infiniteLoopValue}}']"/>
181181
<element name="videoBackgroundLazyLoad" type="text" parameterized="true" selector="(//div[@data-content-type='row'])[{{rowIndex}}][@data-video-lazy-load='{{lazyLoadValue}}']"/>
182-
<element name="videoBackgroundPlayOnlyVisible" type="text" parameterized="true" selector="(//div[@data-content-type='row'])[{{rowIndex}}][@data-video-play-only-visible='{{playOnlyVisibleValue}}']"/>
182+
<element name="videoBackgroundPlayOnlyWhenVisible" type="text" parameterized="true" selector="(//div[@data-content-type='row'])[{{rowIndex}}][@data-video-play-only-visible='{{playOnlyWhenVisibleValue}}']"/>
183183
<element name="videoBackgroundFallbackImage" type="text" parameterized="true" selector="(//div[@data-content-type='row'])[{{rowIndex}}]//div[contains(@id,'jarallax-container')]//img"/>
184184
<element name="videoBackgroundFallbackImageSource" type="text" parameterized="true" selector="(//div[@data-content-type='row'])[{{rowIndex}}]//div[contains(@id,'jarallax-container')]//img[contains(@src,'{{fileName}}')]"/>
185185
<element name="videoBackgroundNoFallbackImage" type="text" parameterized="true" selector="(//div[@data-content-type='row'])[{{rowIndex}}]//div[contains(@id,'jarallax-container')]//div"/>

0 commit comments

Comments
 (0)