adding software rotation support for all display bus types.

There are displays like the ra8876 that do not support hardware rotation and that display uses an SPI or an I8080 bus.

Author: kdschlosser

api_drivers/common_api_drivers/display/ra8876/_ra8876_init.py

@@ -82,6 +82,7 @@ def __init__(
         rgb565_byte_swap=False,
         _cmd_bits=8,
         _param_bits=8,
+        _sw_rotation=False,
         _init_bus=True
     ):
         if power_on_state not in (STATE_HIGH, STATE_LOW):
@@ -130,6 +131,7 @@ def __init__(
         self._rgb565_byte_swap = rgb565_byte_swap
         self._cmd_bits = _cmd_bits
         self._param_bits = _param_bits
+        self._sw_rotation = _sw_rotation
 
         if data_bus is None:
             self._reset_pin = None
@@ -140,47 +142,39 @@ def __init__(
             self._frame_buffer1 = frame_buffer1
             self._frame_buffer2 = frame_buffer2
         else:
-            if reset_pin is None:
-                self._reset_pin = None
-            elif not isinstance(reset_pin, int):
-                self._reset_pin = reset_pin
-            else:
-                self._reset_pin = machine.Pin(reset_pin, machine.Pin.OUT)
-                self._reset_pin.value(not reset_state)
 
-            if power_pin is None:
-                self._power_pin = None
-            elif not isinstance(power_pin, int):
-                self._power_pin = power_pin
+            if isinstance(reset_pin, int):
+                self._reset_pin = machine.Pin(reset_pin, machine.Pin.OUT)
             else:
+                self._reset_pin = reset_pin
+
+            if isinstance(power_pin, int):
                 self._power_pin = machine.Pin(power_pin, machine.Pin.OUT)
-                self._power_pin.value(not power_on_state)
+            else:
+                self._power_pin = power_pin
 
-            if backlight_pin is None:
-                self._backlight_pin = None
-            elif not isinstance(backlight_pin, int):
-                self._backlight_pin = backlight_pin
+            if isinstance(backlight_pin, int):
+                self._backlight_pin = machine.Pin(backlight_pin, machine.Pin.OUT)  # NOQA
             else:
-                self._backlight_pin = machine.Pin(
-                    backlight_pin,
-                    machine.Pin.OUT
-                )
+                self._backlight_pin = backlight_pin
 
             if backlight_on_state == STATE_PWM:
-                if isinstance(self._backlight_pin, io_expander_framework.Pin):
-                    backlight_on_state = STATE_HIGH
+                if isinstance(self._backlight_pin, machine.Pin):
+                    self._backlight_pin = machine.PWM(self._backlight_pin, freq=38000)  # NOQA
                 else:
-                    self._backlight_pin = machine.PWM(
-                        self._backlight_pin, freq=38000)
-
-            if (
-                backlight_on_state != STATE_PWM and
-                self._backlight_pin is not None
-            ):
-                self._backlight_pin.value(not backlight_on_state)
+                    backlight_on_state = STATE_HIGH
 
             self._backlight_on_state = backlight_on_state
 
+            if self._reset_pin:
+                self._reset_pin.value(not reset_state)
+
+            if self._power_pin:
+                self._power_pin.value(not power_on_state)
+
+            if backlight_on_state != STATE_PWM and self._backlight_pin:
+                self._backlight_pin.value(not backlight_on_state)
+
             self._data_bus = data_bus
             self._disp_drv = lv.display_create(display_width, display_height)  # NOQA
             self._disp_drv.set_color_format(color_space)
@@ -238,7 +232,8 @@ def _init_bus(self):
             buffer_size,
             self._rgb565_byte_swap,
             self._cmd_bits,
-            self._param_bits
+            self._param_bits,
+            self._sw_rotation
         )
 
         self._disp_drv.set_flush_cb(self._flush_cb)
@@ -296,7 +291,7 @@ def _on_size_change(self, _):
             self._param_buf[0] = (self._madctl(
                 self._color_byte_order, self._ORIENTATION_TABLE, ~rotation
             ))
-            self._data_bus.tx_param(_MADCTL, self._param_mv[:1])
+            self.set_params(_MADCTL, self._param_mv[:1])
 
     @staticmethod
     def get_displays():
@@ -482,7 +477,7 @@ def init(self, type=None):  # NOQA
         self._initilized = True
 
     def set_params(self, cmd, params=None):
-        self._data_bus.tx_param(cmd, params)
+        self._data_bus.tx_param(cmd, params, False, False)
 
     def get_params(self, cmd, params):
         self._data_bus.rx_param(cmd, params)
@@ -551,22 +546,33 @@ def _dummy_set_memory_location(self, *_, **__):  # NOQA
 
     def _set_memory_location(self, x1, y1, x2, y2):
         # Column addresses
-        param_buf = self._param_buf  # NOQA
+
+        if self._sw_rotation:
+            param_buf = bytearray(4)
+        else:
+            param_buf = self._param_buf
 
         param_buf[0] = (x1 >> 8) & 0xFF
         param_buf[1] = x1 & 0xFF
         param_buf[2] = (x2 >> 8) & 0xFF
         param_buf[3] = x2 & 0xFF
 
-        self._data_bus.tx_param(_CASET, self._param_mv)
+        if self._sw_rotation:
+            self._data_bus.tx_param(_CASET, param_buf, True, False)
+            param_buf = bytearray(4)
+        else:
+            self.set_params(_CASET, self._param_mv)
 
         # Page addresses
         param_buf[0] = (y1 >> 8) & 0xFF
         param_buf[1] = y1 & 0xFF
         param_buf[2] = (y2 >> 8) & 0xFF
         param_buf[3] = y2 & 0xFF
 
-        self._data_bus.tx_param(_RASET, self._param_mv)
+        if self._sw_rotation:
+            self._data_bus.tx_param(_RASET, param_buf, True, True)
+        else:
+            self.set_params(_RASET, self._param_mv)
 
         return _RAMWR
 

api_drivers/common_api_drivers/display/ra8876/_ra8876_type1.py

@@ -14,8 +14,8 @@
 
         mp_obj_t callback;
 
-        void *buf1;
-        void *buf2;
+        mp_obj_array_t *view1;
+        mp_obj_array_t *view2;
         uint32_t buffer_flags;
 
         bool trans_done;

api_drivers/common_api_drivers/display/ra8876/ra8876.py

@@ -19,8 +19,8 @@
 
             mp_obj_t callback;
 
-            void *buf1;
-            void *buf2;
+            mp_obj_array_t *view1;
+            mp_obj_array_t *view2;
             uint32_t buffer_flags;
 
             bool trans_done;

api_drivers/py_api_drivers/frozen/display/display_driver_framework.py

@@ -14,8 +14,8 @@
 
         mp_obj_t callback;
 
-        void *buf1;
-        void *buf2;
+        mp_obj_array_t *view1;
+        mp_obj_array_t *view2;
         uint32_t buffer_flags;
 
         bool trans_done;

ext_mod/lcd_bus/common_include/i2c_bus.h

@@ -18,8 +18,8 @@
 
             mp_obj_t callback;
 
-            void *buf1;
-            void *buf2;
+            mp_obj_array_t *view1;
+            mp_obj_array_t *view2;
             uint32_t buffer_flags;
 
             bool trans_done;

ext_mod/lcd_bus/common_include/i80_bus.h

@@ -0,0 +1,40 @@
+#include "freertos/FreeRTOS.h"
+#include "freertos/task.h"
+#include "freertos/semphr.h"
+#include "freertos/event_groups.h"
+#include "freertos/idf_additions.h"
+
+
+#ifndef __BUS_TASK_H__
+    #define __BUS_TASK_H__
+
+    typedef struct _bus_lock_t {
+        SemaphoreHandle_t handle;
+        StaticSemaphore_t buffer;
+    } bus_lock_t;
+
+    typedef struct _bus_event_t {
+        EventGroupHandle_t handle;
+        StaticEventGroup_t buffer;
+    } bus_event_t;
+
+
+    void bus_event_init(bus_event_t *event);
+    void bus_event_delete(bus_event_t *event);
+    bool bus_event_isset(bus_event_t *event);
+    void bus_event_set(bus_event_t *event);
+    void bus_event_clear(bus_event_t *event);
+    void bus_event_clear_from_isr(bus_event_t *event);
+    bool bus_event_isset_from_isr(bus_event_t *event);
+    void bus_event_set_from_isr(bus_event_t *event);
+    void bus_event_wait(bus_event_t *event);
+
+    int  bus_lock_acquire(bus_lock_t *lock, int32_t wait_ms);
+    void bus_lock_release(bus_lock_t *lock);
+    void bus_lock_init(bus_lock_t *lock);
+    void bus_lock_delete(bus_lock_t *lock);
+    void bus_lock_release_from_isr(bus_lock_t *lock);
+
+#endif
+
+

ext_mod/lcd_bus/common_include/rgb_bus.h

@@ -24,14 +24,17 @@
         typedef struct _mp_lcd_dsi_bus_obj_t {
             mp_obj_base_t base;
 
+            rotation_t *rotation;
+
             mp_obj_t callback;
 
-            void *buf1;
-            void *buf2;
+            mp_obj_array_t *view1;
+            mp_obj_array_t *view2;
+
             uint32_t buffer_flags;
 
-            bool trans_done;
-            bool rgb565_byte_swap;
+            uint8_t trans_done : 1;
+            uint8_t rgb565_byte_swap : 1;
 
             lcd_panel_io_t panel_io_handle;