Fix signTx function

Author: ThibaultJRD

src/client/LumClient.ts

@@ -267,29 +267,39 @@ export class LumClient {
     /**
      * Signs the messages using the provided wallet and builds the transaction
      *
-     * @param wallets signing wallets for multi signature
+     * @param wallet signing wallet for multi signature
      * @param doc document to sign
      */
-    signTx = async <T>(wallets: T, doc: LumTypes.Doc): Promise<Uint8Array> => {
-        let signDoc: LumTypes.SignDoc | undefined = undefined;
+    signTx = async (wallet: LumWallet, doc: LumTypes.Doc): Promise<Uint8Array> => {
         const signatures: Uint8Array[] = [];
+        const [signedDoc, signature] = await this.signTxFromWallet(wallet, doc);
 
-        if (wallets instanceof LumWallet) {
-            const [walletSignedDoc, signature] = await this.signTxFromWallet(wallets, doc);
+        signatures.push(signature);
 
-            signatures.push(signature);
-            signDoc = walletSignedDoc;
+        if (!signedDoc || signatures.length === 0) {
+            throw new Error('Failed to sign the document: no signature provided');
         }
 
-        if (wallets instanceof Array) {
-            for (const wallet of wallets) {
-                const [walletSignedDoc, signature] = await this.signTxFromWallet(wallet, doc);
+        return LumUtils.generateTxBytes(signedDoc, signatures);
+    };
 
-                signatures.push(signature);
+    /**
+     * Signs the messages using the provided wallets and builds the transaction
+     *
+     * @param wallets signing wallets for multi signature
+     * @param doc document to sign
+     */
+    signTxForMultiWallet = async (wallets: LumWallet[], doc: LumTypes.Doc): Promise<Uint8Array> => {
+        let signDoc: LumTypes.SignDoc | undefined = undefined;
+        const signatures: Uint8Array[] = [];
 
-                if (!signDoc) {
-                    signDoc = walletSignedDoc;
-                }
+        for (const wallet of wallets) {
+            const [walletSignedDoc, signature] = await this.signTxFromWallet(wallet, doc);
+
+            signatures.push(signature);
+
+            if (!signDoc) {
+                signDoc = walletSignedDoc;
             }
         }
 
@@ -326,8 +336,15 @@ export class LumClient {
      * @param wallet signing wallet or wallets for multi signature
      * @param doc document to sign and broadcast as a transaction
      */
-    signAndBroadcastTx = async (wallet: LumWallet | LumWallet[], doc: LumTypes.Doc): Promise<LumTypes.BroadcastTxCommitResponse> => {
+    signAndBroadcastTx = async (wallet: LumWallet, doc: LumTypes.Doc): Promise<LumTypes.BroadcastTxCommitResponse> => {
         const signedTx = await this.signTx(wallet, doc);
+
+        return this.broadcastTx(signedTx);
+    };
+
+    signAndBroadcastTxForMultiWallet = async (wallets: LumWallet[], doc: LumTypes.Doc): Promise<LumTypes.BroadcastTxCommitResponse> => {
+        const signedTx = await this.signTxForMultiWallet(wallets, doc);
+
         return this.broadcastTx(signedTx);
     };
 }

src/registry/aminoTypes.ts

@@ -39,7 +39,6 @@ export const createDefaultAminoTypes = (): { [p: string]: AminoConverter | 'not_
 
 export const createAminoTypes = (): { [p: string]: AminoConverter | 'not_supported_by_chain' } => {
     return {
-        ...createDefaultAminoTypes(),
         // DFract
 
         '/lum.network.dfract.MsgDeposit': {