Skip to content

Commit f86fcd3

Browse files
author
Faran
committed
hide custom scrolls on virtualization
1 parent 3ae83d5 commit f86fcd3

File tree

2 files changed

+22
-3
lines changed

2 files changed

+22
-3
lines changed

client/packages/lowcoder/src/comps/comps/tableLiteComp/parts/TableContainer.tsx

Lines changed: 19 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ const MainContainer = styled.div<{
88
$mode: 'AUTO' | 'FIXED';
99
$showHorizontalScrollbar: boolean;
1010
$showVerticalScrollbar: boolean;
11+
virtual: boolean;
1112
}>`
1213
display: flex;
1314
flex-direction: column;
@@ -17,13 +18,13 @@ const MainContainer = styled.div<{
1718
/* Critical CSS controls for SimpleBar */
1819
1920
20-
${props => !props.$showHorizontalScrollbar && `
21+
${props => (!props.$showHorizontalScrollbar || props.virtual) && `
2122
div.simplebar-horizontal {
2223
visibility: hidden !important;
2324
}
2425
`}
2526
26-
${props => !props.$showVerticalScrollbar && `
27+
${props => (!props.$showVerticalScrollbar || props.virtual) && `
2728
div.simplebar-vertical {
2829
visibility: hidden !important;
2930
}
@@ -60,6 +61,13 @@ const TableSection = styled.div<{
6061
}>`
6162
min-height: 0;
6263
min-width: 0;
64+
65+
/* Ant Table virtualization scrollbar - match SimpleBar colors */
66+
.ant-table-tbody-virtual-scrollbar-thumb {
67+
background: rgba(0,0,0,0.35) !important;
68+
border-radius: 6px;
69+
transition: background .2s ease;
70+
}
6371
`;
6472

6573
const SimpleBarWrapper = styled(SimpleBar)`
@@ -97,6 +105,7 @@ interface TableContainerProps {
97105
containerRef?: React.RefObject<HTMLDivElement>;
98106
showVerticalScrollbar: boolean;
99107
showHorizontalScrollbar: boolean;
108+
virtual: boolean;
100109
}
101110

102111
export const TableContainer: React.FC<TableContainerProps> = ({
@@ -108,16 +117,23 @@ export const TableContainer: React.FC<TableContainerProps> = ({
108117
children,
109118
containerRef,
110119
showVerticalScrollbar,
111-
showHorizontalScrollbar
120+
showHorizontalScrollbar,
121+
virtual
112122
}) => {
113123
const hideScrollbar = !showHorizontalScrollbar && !showVerticalScrollbar;
114124

125+
React.useEffect(() => {
126+
// eslint-disable-next-line no-console
127+
console.log('TableContainer virtual:', virtual);
128+
}, [virtual]);
129+
115130
return (
116131
<MainContainer
117132
$mode={mode}
118133
ref={containerRef}
119134
$showHorizontalScrollbar={showHorizontalScrollbar}
120135
$showVerticalScrollbar={showVerticalScrollbar}
136+
virtual={virtual}
121137
>
122138
{/* Sticky above toolbar - always visible */}
123139
{stickyToolbar && toolbarPosition === 'above' && showToolbar && (

client/packages/lowcoder/src/comps/comps/tableLiteComp/tableCompView.tsx

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -183,6 +183,8 @@ export const TableCompView = React.memo((props: {
183183
toolbar={toolbarView}
184184
showVerticalScrollbar={compChildren.showVerticalScrollbar.getView()}
185185
showHorizontalScrollbar={compChildren.showHorizontalScrollbar.getView()}
186+
virtual={virtualization.enabled}
187+
containerRef={containerRef}
186188
>
187189
<EmptyContent text={trans("table.emptyColumns")} />
188190
</TableContainer>
@@ -203,6 +205,7 @@ export const TableCompView = React.memo((props: {
203205
containerRef={containerRef}
204206
showVerticalScrollbar={compChildren.showVerticalScrollbar.getView()}
205207
showHorizontalScrollbar={compChildren.showHorizontalScrollbar.getView()}
208+
virtual={virtualization.enabled}
206209
>
207210

208211
<TableRenderer<any>

0 commit comments

Comments
 (0)