Skip to content

Commit 0a92dd1

Browse files
committed
Remove moment.js dependency and fix UTC time string conversion to local time date object
1 parent b919870 commit 0a92dd1

File tree

5 files changed

+16
-4
lines changed

5 files changed

+16
-4
lines changed

package.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,11 @@
1818
"typescript": "^2.5.2"
1919
},
2020
"dependencies": {
21+
"@types/moment": "^2.13.0",
2122
"bignumber.js": "^4.0.3",
2223
"got": "^7.1.0",
2324
"json2typescript": "^1.0.2",
25+
"moment": "^2.20.0",
2426
"query-string": "^5.0.0",
2527
"retry-promise-typescript": "^1.0.5",
2628
"tslib": "^1.7.1"

src/model/DataConverter.js

Lines changed: 1 addition & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/model/DataConverter.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/model/DataConverter.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import {JsonConverter, JsonCustomConvert} from 'json2typescript';
22
import BigNumber from 'bignumber.js';
3+
import * as moment from "moment";
34

45
// Disable the error about 15 decimal places
56
// Happens during Bittrex.marketSummaries()
@@ -12,7 +13,7 @@ export class DateConverter implements JsonCustomConvert<Date> {
1213
}
1314

1415
deserialize(date: any): Date {
15-
return new Date(date + 'Z');
16+
return moment.utc(date).toDate();
1617
}
1718
}
1819

yarn.lock

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,12 @@
88
dependencies:
99
"@types/node" "*"
1010

11+
"@types/moment@^2.13.0":
12+
version "2.13.0"
13+
resolved "https://registry.yarnpkg.com/@types/moment/-/moment-2.13.0.tgz#604ebd189bc3bc34a1548689404e61a2a4aac896"
14+
dependencies:
15+
moment "*"
16+
1117
"@types/node@*", "@types/node@^8.0.26":
1218
version "8.0.28"
1319
resolved "https://registry.yarnpkg.com/@types/node/-/node-8.0.28.tgz#86206716f8d9251cf41692e384264cbd7058ad60"
@@ -160,6 +166,10 @@ mkdirp@^0.5.1:
160166
dependencies:
161167
minimist "0.0.8"
162168

169+
moment@*, moment@^2.20.0:
170+
version "2.20.0"
171+
resolved "https://registry.yarnpkg.com/moment/-/moment-2.20.0.tgz#53396358994dd3a551e966a66af715ecb6c30ad0"
172+
163173
object-assign@^4.1.0:
164174
version "4.1.1"
165175
resolved "https://registry.yarnpkg.com/object-assign/-/object-assign-4.1.1.tgz#2109adc7965887cfc05cbbd442cac8bfbb360863"

0 commit comments

Comments
 (0)