Skip to content

Commit 085614a

Browse files
committed
axe gulp-responsive and the app-icon task
there just doesnt seem to be a modern supported version of gulp-responsive, and building these outdated app icons are not high value. we do miss out on 32x32 favicon for those whos browsers would use it, and the apple homescreen icon, but eh
1 parent 5e36554 commit 085614a

File tree

3 files changed

+4
-796
lines changed

3 files changed

+4
-796
lines changed

gulpfile.js

Lines changed: 1 addition & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ const cssnano = require('gulp-cssnano')
1818
const htmlmin = require('gulp-htmlmin')
1919
const imagemin = require('gulp-imagemin')
2020
const purgeCss = require('gulp-purgecss')
21-
// const responsive = require('gulp-responsive') // Disabled: old Sharp version incompatible with Node 22
2221
const terser = require('gulp-terser')
2322

2423
const base = './'
@@ -89,14 +88,6 @@ const plugins = {
8988
'purgeCss': {
9089
},
9190

92-
'responsive': {
93-
'errorOnEnlargement': false,
94-
'errorOnUnusedImage': false,
95-
'silent': true,
96-
'stats': false,
97-
'withoutEnlargement': false
98-
},
99-
10091
'terser': {
10192
'compress': {
10293
'collapse_vars': true,
@@ -318,15 +309,6 @@ gulp.task('minify-xml', () =>
318309
/*----------------------------------------------------------------------------*/
319310

320311
// Individual build tasks
321-
// Disabled: gulp-responsive uses old Sharp incompatible with Node 22
322-
// gulp.task('build-app-icons', () =>
323-
// pump([
324-
// gulpSrc(['**/*.{png,svg}', '!_site/**/*'], opts),
325-
// responsive(require('./icons'), plugins.responsive),
326-
// gulp.dest('_site/icons/')
327-
// ], cb)
328-
// )
329-
330312
gulp.task('build-favicon', () =>
331313
globby('_site/icons/favicon-*.png')
332314
.then(files => Promise.all(files.map(file => fs.readFile(file))))
@@ -343,7 +325,7 @@ gulp.task('build-redirects', () => cleanFile('_site/_redirects'))
343325
// Composite build tasks
344326
gulp.task('build-css', gulp.series('minify-css'))
345327
gulp.task('build-html', gulp.series('minify-html'))
346-
gulp.task('build-images', gulp.series('build-favicon', 'minify-images')) // build-app-icons disabled
328+
gulp.task('build-images', gulp.series('build-favicon', 'minify-images'))
347329
gulp.task('build-js', gulp.series('build-sw', 'minify-js'))
348330
gulp.task('build-metadata', gulp.parallel('build-appcache', 'minify-xml'))
349331

0 commit comments

Comments
 (0)