Added support for explicit variables mode, descriptions for the settings, documented explicit variables mode and that the server engine must be 7.1+ because the linter uses commandArguments. Also some changes to main.coffee to kill errors from the coffee linter.

Author: Monte Goulding

README.md

@@ -48,7 +48,7 @@ script compilation errors on the fly.
 Dependencies:
 
  * The [linter package](https://atom.io/packages/linter) needs to be installed
- * LiveCode Server engine for the platform it is being run on must be accessible
+ * LiveCode 7.1+ Server engine for the platform it is being run on must be accessible
 
 The default setting assumes you have installed the LiveCode Server engine somewhere
 on the current `$PATH` with the name `livecode-server`. However, you can enter any
@@ -58,6 +58,9 @@ For LiveCode Server the linter will only check for errors within the scope of
 the file being edited. If for example a variable re-declarition error is caused
 by the inclusion of another file that error won't be detected.
 
+The linter supports an optional explicit variables mode which can be turned on
+via the package settings.
+
 ## Authors
 
 * Ralf Bitter

lib/main.coffee

@@ -6,12 +6,22 @@ module.exports =
       type: 'string'
       title: 'LiveCode Server Engine Path'
       default: 'livecode-server' # Let OS's $PATH handle the rest
+      description: 'Where is your livecode server installed? ' +
+        'Default assumes it\'s on $PATH'
+    explicitVars:
+      type: 'boolean'
+      title: 'Explicit Variables'
+      default: 'false'
+      description: 'Get errors on undeclared variables'
 
   activate: ->
     @subscriptions = new CompositeDisposable
     @subscriptions.add atom.config.observe 'language-livecode.executablePath',
       (executablePath) =>
         @executablePath = executablePath
+    @subscriptions.add atom.config.observe 'language-livecode.explicitVars',
+      (explicitVars) =>
+        @explicitVars = explicitVars
     path = require 'path'
     @linterPath = path.join(__dirname, '..', 'tools', 'Linter.lc')
 
@@ -25,21 +35,27 @@ module.exports =
       scope: 'file'
       lintOnFly: true
       lint: (textEditor) =>
-          filePath = textEditor.getPath()
-          command = @executablePath
-          parameters = []
-          stackfile = @linterPath
-          parameters.push(stackfile)
-          scope = '-scope=' + textEditor.getRootScopeDescriptor()
-          parameters.push(scope)
-          text = textEditor.getText()
-          return helpers.exec(command, parameters, {stdin: text}).then (output) ->
-            regex = /(\d+),(\d+),(.*)/g
-            messages = []
-            while((match = regex.exec(output)) isnt null)
-              messages.push
-                type: "Error"
-                filePath: filePath
-                range: [[match[1]-1, match[2]-0],[match[1]-1, textEditor.getBuffer().lineLengthForRow(match[1]-1)]]
-                text: match[3]
-            return messages
+        filePath = textEditor.getPath()
+        command = @executablePath
+        parameters = []
+        stackfile = @linterPath
+        parameters.push(stackfile)
+        scope = '-scope=' + textEditor.getRootScopeDescriptor()
+        parameters.push(scope)
+        explicitVariables = '-explicitVariables=' + @explicitVars
+        parameters.push(explicitVariables)
+        text = textEditor.getText()
+        return helpers.exec(command, parameters, {stdin: text}).then (output) ->
+          regex = /(\d+),(\d+),(.*)/g
+          messages = []
+          while((match = regex.exec(output)) isnt null)
+            line = match[1]-1
+            messages.push
+              type: "Error"
+              filePath: filePath
+              range: [
+                [line, match[2]-0],
+                [line, textEditor.getBuffer().lineLengthForRow(line)]
+              ]
+              text: match[3]
+          return messages

tools/Linter.lc

@@ -6,15 +6,19 @@ local sLastLine
 Lint
 
 command Lint
-  local tScope
+  local tScope, theArgument
   repeat for each element theArgument in the commandArguments
     if theArgument begins with "-scope" then
        split theArgument with "="
        put theArgument[2] into tScope
+   else if theArgument begins with "-explicitVariables" then
+      split theArgument with "="
+      set the explicitVariables to theArgument[2]
     end if
   end repeat
 
   read from stdin until empty
+  local tScript
   put it into tScript
 
   put the scriptParsingErrors into sErrorsList
@@ -36,10 +40,13 @@ command Lint
 
     set the script of stack "TestScript" to tScript
 
+    local theErrors
     put the result into theErrors
     split theErrors with return
+    local tIndex
     repeat with tIndex = 1 to the number of elements in theErrors
       if theErrors[tIndex] is not empty then
+        local tMessage
         put sErrorsList[item 1 of theErrors[tIndex]] into tMessage
         if tMessage is not empty then
           if item 4 of theErrors[tIndex] is not empty then
@@ -51,6 +58,7 @@ command Lint
     end repeat
   else if tScope is ".source.iRev" then
     -- write out to a temporary file and include
+    local tFile
     put the temporary folder & slash & uuid() into tFile
     -- can't lint a whole web app...
     replace "include" with "# include" in tScript
@@ -67,14 +75,14 @@ command Lint
 end Lint
 
 command scriptExecutionError pStack, pFiles
-  local tHint, tFile
-  --write 1,1,line 2 of pStack & linefeed to stdout
   split pStack with return
+  local tIndex
   repeat with tIndex = 2 to the number of elements in pStack
     if item 1 of pStack[tIndex] is 730 then
       exit repeat
     end if
     if item 2 of pStack[tIndex] is not 0 and item 2 of pStack[tIndex] is not sLastLine then
+      local tMessage
       put sErrorsList[item 1 of pStack[tIndex]] into tMessage
       if tMessage is not empty then
         if item 4 of pStack[tIndex] is not empty then
@@ -86,6 +94,7 @@ command scriptExecutionError pStack, pFiles
   end repeat
 
   -- cleanup
+  local tFile
   set the itemDelimiter to slash
   repeat for each line tFile in pFiles
     if item -1 of tFile is "Linter.lc" then