net: macb: free resources in case of failure

In case macb_open() fails and user space tries to "ifup" the again
the interface after this failure, the napi_enable() will reach a
BUG_ON() instruction because the napi wasn't disabled the the
previous macb_open() failure. So, add failure path in macb_open()
that reverts the previously done operations.

Fixes: b2b0414 ("net: macb: convert to phylink")
Tested-by: Cristian Birsan <cristian.birsan@microchip.com>
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>

Author: claudiubeznea

drivers/net/ethernet/cadence/macb_main.c

@@ -2500,7 +2500,7 @@ static int macb_open(struct net_device *dev)
 
 	err = macb_phylink_connect(bp);
 	if (err)
-		goto pm_exit;
+		goto reset_hw;
 
 	netif_tx_start_all_queues(dev);
 
@@ -2509,6 +2509,12 @@ static int macb_open(struct net_device *dev)
 
 	return 0;
 
+reset_hw:
+	macb_reset_hw(bp);
+	for (q = 0, queue = bp->queues; q < bp->num_queues; ++q, ++queue)
+		napi_disable(&queue->napi);
+	macb_free_consistent(bp);
+
 pm_exit:
 	pm_runtime_put_sync(&bp->pdev->dev);