Skip to content

Commit 58f4fe2

Browse files
ambarusvarshini-rajendran
authored andcommitted
mtd: spi-nor: macronix: Fix readid protocol at octal dtr disable
nor->proto is not updated yet after disable, thus we should explicitly use SNOR_PROTO_1_1_1. This fixes the following error: dma dma0chan8: read bus error!!! What happened is that we used octal DTR proto for reading, the flash rejected the opcode, and DMA waited indefinitly. Fixing the protocol solves the issue. Fixes: 1856631 ("mtd: spi-nor: macronix: Add support for mx66lm1g45g") Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com> Tested-by: Claudiu Beznea <claudiu.beznea@microchip.com>
1 parent 637552b commit 58f4fe2

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/mtd/spi-nor/macronix.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ static int spi_nor_macronix_octal_dtr_dis(struct spi_nor *nor)
9696
if (ret)
9797
return ret;
9898

99-
ret = spi_nor_read_id(nor, 0, 0, buf, nor->reg_proto);
99+
ret = spi_nor_read_id(nor, 0, 0, buf, SNOR_PROTO_1_1_1);
100100
if (ret)
101101
return ret;
102102

0 commit comments

Comments
 (0)