igb: Initialize mailbox message for VF reset

anguy11 · gregkh · commit 367e1e3399db · 2022-12-21T17:36:37.000+01:00
commit de5dc44 upstream. When a MAC address is not assigned to the VF, that portion of the message sent to the VF is not set. The memory, however, is allocated from the stack meaning that information may be leaked to the VM. Initialize the message buffer to 0 so that no information is passed to the VM in this case. Fixes: 6ddbc4c ("igb: Indicate failure on vf reset for empty mac address") Reported-by: Akihiko Odaki <akihiko.odaki@daynix.com> Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com> Reviewed-by: Akihiko Odaki <akihiko.odaki@daynix.com> Reviewed-by: Leon Romanovsky <leonro@nvidia.com> Link: https://lore.kernel.org/r/20221212190031.3983342-1-anthony.l.nguyen@intel.com Signed-off-by: Jakub Kicinski <kuba@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c
@@ -7410,7 +7410,7 @@ static void igb_vf_reset_msg(struct igb_adapter *adapter, u32 vf)
 {
 	struct e1000_hw *hw = &adapter->hw;
 	unsigned char *vf_mac = adapter->vf_data[vf].vf_mac_addresses;
-	u32 reg, msgbuf[3];
+	u32 reg, msgbuf[3] = {};
 	u8 *addr = (u8 *)(&msgbuf[1]);
 
 	/* process all the same items cleared in a function level reset */

Original file line number	Diff line number	Diff line change
`@@ -7410,7 +7410,7 @@ static void igb_vf_reset_msg(struct igb_adapter *adapter, u32 vf)`
`7410`	`7410`	`{`
`7411`	`7411`	`struct e1000_hw *hw = &adapter->hw;`
`7412`	`7412`	`unsigned char *vf_mac = adapter->vf_data[vf].vf_mac_addresses;`
`7413`		`- u32 reg, msgbuf[3];`
	`7413`	`+ u32 reg, msgbuf[3] = {};`
`7414`	`7414`	`u8 addr = (u8 )(&msgbuf[1]);`
`7415`	`7415`
`7416`	`7416`	`/* process all the same items cleared in a function level reset */`