Commit 7faf887
Python SDK for ACLP Alerts (#589)
* DI-26927 Python SDK code for GET Alert Definitions
* DI-26927 Python SDK code modified for client code
* DI-26927 Added Unit test cases and missing classes
* DI-26927 made corrections to keep code consistent
* DI-26927 Updated Unit and Integratoion Tests
* [dev 51950af] DI-26927 Updated Unit and Integratoion Tests
* Revert "DI-26927 Updated Unit and Integratoion Tests"
This reverts commit 51950af.
* Revert "[dev 51950af] DI-26927 Updated Unit and Integratoion Tests"
This reverts commit 6ca6a5a.
* DI-26927 Updated Unit and Integratoion Tests
* Remove .venv from repo and add to .gitignore
* DI-26927 reverted git ignore
* DI-26927 reverted conftest,py
* DI-26927 added accidentlly deleted file
* DI-26927 Corrected Integration and Unit Test cases for Alerting APIs
* DI-26927 Reverted conftest.py and check integration without those changes
* DI-26927 fixed integration test for firewall and added time for alert update before deletion
* DI-26927 fixed changing monitor.py as per review comments
* DI-26927 fixed changing monitor.py as per review comments
* DI-26927 fixed changing monitor.py as per review comments
* DI-26927 Intermediate change to address internal review comments
* DI-26927 CLosed review comments
* DI-26927 CLosed review comments
* DI-27156 closed review comments from Ketan
* DI-27156 closed review comments from Ketan
* DI-27156 fixed unit test cases post review comments fixes
* DI-27156 Updated docstring and make unit test cases changes
* DI-27156 Added unit test cases post review comments fixes
* DI-27156 Added unit test cases post review comments fixes
* tests(monitor): add MonitorAlertDefinitionsTest and update fixtures for alert-definitions
* DI-27156 Added unit test cases post review comments fixes
* DI-27156 Updated docstring
* DI-27156 Updated unit test errors
* removed unwanted files
* added missing doxcstring
* added missing doxcstring
* added missing doxcstring
* rmoved test files
* closed final review comments
* fixing integration test issues
* Corrected Integration Test Case
* DI-26927 Corrected json to object modifications issues
* DI-26927 Corrected json to object modifications issues
* DI-26927 Unit test corrections for mofied functions name
* Delete test/fixtures/monitor/services/dbaas/alert-definitions.json
Not Required
* Delete test.py
Not Required here required for local testing only
* Delete test/fixtures/monitor/alert-definitions.json
Not required here
* DI-26927 reverted fixtures.py as its not necesary to change
* DI-26927 reverted fixtures.py as its not necesary to change
* DI-26927 reverted fixtures.py as its not necesary to change
* DI-26927 fixed linting error
* DI-26927 fixed linting error
* DI-26927 fixed lint error caught in CI
* Update test/unit/groups/monitor_api_test.py
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Update test/integration/models/monitor/test_monitor.py
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Update test/integration/models/monitor/test_monitor.py
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Update test/integration/models/monitor/test_monitor.py
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Update linode_api4/objects/monitor.py
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* DI-26927 fixed copilot comments
* fixed review comments from APIv4 team
* fixed review comments from APIv4 team
* fixed review comments from APIv4 team
* fixed review comments from APIv4 team
* DI-26927 fixed review comments from API v4 team
* fixed review comments from APIv4 team
* fixed lint errors
* Update linode_api4/groups/monitor.py
Co-authored-by: Ye Chen <127243817+yec-akamai@users.noreply.github.com>
* Update linode_api4/groups/monitor.py
Co-authored-by: Ye Chen <127243817+yec-akamai@users.noreply.github.com>
* fixed review errors
* fixed unittest
* fixed unittest
* fixed unittest
* fixed unittest
* fixed unittest
* fixed unittest
* added update use case to integration test
* Update linode_api4/objects/monitor.py
Co-authored-by: Ye Chen <127243817+yec-akamai@users.noreply.github.com>
* Update linode_api4/objects/monitor.py
Co-authored-by: Ye Chen <127243817+yec-akamai@users.noreply.github.com>
* Update linode_api4/objects/monitor.py
Co-authored-by: Ye Chen <127243817+yec-akamai@users.noreply.github.com>
* Update linode_api4/objects/monitor.py
Co-authored-by: Ye Chen <127243817+yec-akamai@users.noreply.github.com>
* fixed further review comments
* Updated integration test
* Updated integration test with more assert statements
* Fix Linode interfaces property (#604)
* Fix test for interfaces (#605)
* Fix test
* changed as per github-advanced-security comments
* fixed formatting errors using python black
* Migrate test fixtures discovery to be with pathlib (#599)
* Migrate test fixtures discovery to be with pathlib
* Apply suggestion from @Copilot
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Apply suggestion from @Copilot
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
---------
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Update linode_api4/objects/monitor.py
Co-authored-by: Ye Chen <127243817+yec-akamai@users.noreply.github.com>
* Fixed Copilot comments on unit and integration tests
* corrected unit test assert statement
* Added comment as per copilot suggestion for save() and delete()
* resolved comments from copilot commented whereever not applicable
* Test: verify automatic GPG signing is working
* Incorporated copilot comments
* Removed serialisabel file from commit
* Fix Lint errors
* fixed review comments fo mutable
* fixed review comments to keep it in line with SDK guidelines
* Addressed review comments on AlertDefinition class
* Comprehensive monitor API improvements and code quality fixes
- Removed unused imports and optimized import order
- Updated test cases for monitor integration
- Enhanced monitor objects with proper type annotations
- Improved monitor groups with better error handling
- Applied code review feedback and best practices
* Applied review comments across
* Comprehensive monitor API fixes and improvements
- Fixed json_object parameter issues in AlertDefinition properties
- Corrected list type annotations for AlertChannelEnvelope
- Updated integration tests with proper status handling for alert definitions
- Applied review comments for better code quality
- Enhanced type annotations and import organization
- Improved error handling in monitor group methods
* change entity id type as per review comments
* reverted copilot comments as per the suggestion unit and integration test passed after the changes
* removed unused imports
* removed unused imports
* Refactored integration test
* changed _class to alert_class as per review suggestions
* changed alert_class to service_class as per review suggestions
* Update linode_api4/objects/monitor.py
* Update test/integration/models/monitor/test_monitor.py
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Update test/integration/models/monitor/test_monitor.py
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Update linode_api4/groups/monitor.py
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Update test/integration/models/monitor/test_monitor.py
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Update linode_api4/groups/monitor.py
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Update test/fixtures/monitor_alert-definitions.json
* Apply suggestion from @zliang-akamai
* Apply suggestion from @zliang-akamai
---------
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Ye Chen <127243817+yec-akamai@users.noreply.github.com>
Co-authored-by: Zhiwei Liang <121905282+zliang-akamai@users.noreply.github.com>
Co-authored-by: Zhiwei Liang <zliang@akamai.com>1 parent dc3164c commit 7faf887
File tree
8 files changed
+689
-14
lines changed- linode_api4
- groups
- objects
- test
- fixtures
- integration
- models/monitor
- unit/groups
8 files changed
+689
-14
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
2 | | - | |
3 | | - | |
4 | 1 | | |
5 | 2 | | |
6 | 3 | | |
7 | 4 | | |
8 | 5 | | |
9 | 6 | | |
| 7 | + | |
| 8 | + | |
10 | 9 | | |
11 | 10 | | |
12 | 11 | | |
13 | 12 | | |
14 | 13 | | |
15 | 14 | | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
16 | 19 | | |
17 | 20 | | |
18 | 21 | | |
| |||
145 | 148 | | |
146 | 149 | | |
147 | 150 | | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
| 203 | + | |
| 204 | + | |
| 205 | + | |
| 206 | + | |
| 207 | + | |
| 208 | + | |
| 209 | + | |
| 210 | + | |
| 211 | + | |
| 212 | + | |
| 213 | + | |
| 214 | + | |
| 215 | + | |
| 216 | + | |
| 217 | + | |
| 218 | + | |
| 219 | + | |
| 220 | + | |
| 221 | + | |
| 222 | + | |
| 223 | + | |
| 224 | + | |
| 225 | + | |
| 226 | + | |
| 227 | + | |
| 228 | + | |
| 229 | + | |
| 230 | + | |
| 231 | + | |
| 232 | + | |
| 233 | + | |
| 234 | + | |
| 235 | + | |
| 236 | + | |
| 237 | + | |
| 238 | + | |
| 239 | + | |
| 240 | + | |
| 241 | + | |
| 242 | + | |
| 243 | + | |
| 244 | + | |
| 245 | + | |
| 246 | + | |
| 247 | + | |
| 248 | + | |
| 249 | + | |
| 250 | + | |
| 251 | + | |
| 252 | + | |
| 253 | + | |
| 254 | + | |
| 255 | + | |
| 256 | + | |
| 257 | + | |
| 258 | + | |
| 259 | + | |
| 260 | + | |
| 261 | + | |
| 262 | + | |
| 263 | + | |
| 264 | + | |
| 265 | + | |
| 266 | + | |
| 267 | + | |
| 268 | + | |
| 269 | + | |
| 270 | + | |
| 271 | + | |
| 272 | + | |
| 273 | + | |
| 274 | + | |
| 275 | + | |
| 276 | + | |
| 277 | + | |
| 278 | + | |
| 279 | + | |
| 280 | + | |
| 281 | + | |
| 282 | + | |
| 283 | + | |
| 284 | + | |
| 285 | + | |
| 286 | + | |
0 commit comments