updating with review comments

Author: pmajali

linode_api4/objects/monitor.py

@@ -49,7 +49,7 @@ class ServiceType(StrEnum):
     firewall = "firewall"
     object_storage = "object_storage"
     aclb = "aclb"
-    netloadbalancer = "netloadbalancer"
+    net_load_balancer = "netloadbalancer"
 
 
 class MetricType(StrEnum):
@@ -124,7 +124,7 @@ class DashboardWidget(JSONObject):
     y_label: str = ""
     aggregate_function: AggregateFunction = ""
     group_by: List[str] = field(default_factory=list)
-    filters: Optional[List[Filter]] = None
+    filters: List[Filter] = field(default_factory=list)
 
 
 @dataclass

linode_api4/objects/region.py

@@ -1,4 +1,4 @@
-from dataclasses import dataclass
+from dataclasses import dataclass, field
 from typing import List, Optional
 
 from linode_api4.errors import UnexpectedResponseError
@@ -24,14 +24,8 @@ class RegionMonitors(JSONObject):
     use with Akamai Cloud Pulse (ACLP).
     """
 
-    alerts: list[str] | None = None
-    metrics: list[str] | None = None
-
-    def __post_init__(self):
-        if self.alerts is None:
-            self.alerts = []
-        if self.metrics is None:
-            self.metrics = []
+    alerts: list[str] = field(default_factory=list)
+    metrics: list[str] = field(default_factory=list)
 
 
 class Region(Base):

test/unit/objects/monitor_test.py

@@ -127,10 +127,10 @@ def test_metric_definitions(self):
         self.assertEqual(metrics[0].metric_type, "gauge")
         self.assertEqual(metrics[0].scrape_interval, "60s")
         self.assertEqual(metrics[0].unit, "percent")
-        self.assertEqual(metrics[0].dimensions[0]["dimension_label"], "node_type")
-        self.assertEqual(metrics[0].dimensions[0]["label"], "Node Type")
+        self.assertEqual(metrics[0].dimensions[0].dimension_label, "node_type")
+        self.assertEqual(metrics[0].dimensions[0].label, "Node Type")
         self.assertEqual(
-            metrics[0].dimensions[0]["values"], ["primary", "secondary"]
+            metrics[0].dimensions[0].values, ["primary", "secondary"]
         )
 
     def test_create_token(self):