docker: use stages for nodejs and golang parts

With this commit we split the build process into three stages: we start
with the JavaScript to static asset build process that requires NodeJS
then copy the result into the second stage that requires golang.
Finally, we just extract the final binaries in the third stage to keep
the shipped image as small as possible.

Author: guggero

Dockerfile

@@ -1,38 +1,42 @@
-FROM golang:1.15.5-alpine as builder
-
-# Force Go to use the cgo based DNS resolver. This is required to ensure DNS
-# queries required to connect to linked containers succeed.
-ENV GODEBUG netdns=cgo
+# Start with a NodeJS base image that also contains yarn.
+FROM node:12.17.0-alpine as nodejsbuilder
 
 # Pass a tag, branch or a commit using build-arg. This allows a docker image to
 # be built from a specified Git state. The default image will use the Git tip of
 # master by default.
 ARG checkout="master"
 
+RUN apk add --no-cache --update alpine-sdk \
+    git \
+  && git clone https://github.com/lightninglabs/lightning-terminal /go/src/github.com/lightninglabs/lightning-terminal \
+  && cd /go/src/github.com/lightninglabs/lightning-terminal \
+  && git checkout $checkout \
+  && cd app \
+  && yarn install \
+  && yarn build
+
+# The first stage is already done and all static assets should now be generated
+# in the app/build sub directory.
+FROM golang:1.15.5-alpine as golangbuilder
+
+# Instead of checking out from git again, we just copy the whole working
+# directory of the previous stage that includes the generated static assets.
+COPY --from=nodejsbuilder /go/src/github.com/lightninglabs/lightning-terminal /go/src/github.com/lightninglabs/lightning-terminal
+
+# Force Go to use the cgo based DNS resolver. This is required to ensure DNS
+# queries required to connect to linked containers succeed.
+ENV GODEBUG netdns=cgo
+
 # Explicitly turn on the use of modules (until this becomes the default).
 ENV GO111MODULE on
 
-ENV NODE_VERSION=v12.17.0
-
 # Install dependencies and install/build lightning-terminal.
 RUN apk add --no-cache --update alpine-sdk \
-    git \
     make \
-    curl \
-    bash \
-    binutils \
-    tar \
-&& touch ~/.bashrc \
-&& curl -sfSLO https://unofficial-builds.nodejs.org/download/release/${NODE_VERSION}/node-${NODE_VERSION}-linux-x64-musl.tar.xz \
-&& tar -xf node-${NODE_VERSION}-linux-x64-musl.tar.xz -C /usr --strip 1 \
-&& rm node-${NODE_VERSION}-linux-x64-musl.tar.xz \
-&& curl -o- -L https://yarnpkg.com/install.sh | bash \
-&& . ~/.bashrc \
-&& git clone https://github.com/lightninglabs/lightning-terminal /go/src/github.com/lightninglabs/lightning-terminal \
-&& cd /go/src/github.com/lightninglabs/lightning-terminal \
-&& git checkout $checkout \
-&& make install \
-&& make go-install-cli
+  && cd /go/src/github.com/lightninglabs/lightning-terminal \
+  && make statik-only \
+  && make go-install \
+  && make go-install-cli
 
 # Start a new, final image to reduce size.
 FROM alpine as final
@@ -44,11 +48,11 @@ VOLUME /root/.lnd
 EXPOSE 8443 10009 9735
 
 # Copy the binaries and entrypoint from the builder image.
-COPY --from=builder /go/bin/litd /bin/
-COPY --from=builder /go/bin/lncli /bin/
-COPY --from=builder /go/bin/frcli /bin/
-COPY --from=builder /go/bin/loop /bin/
-COPY --from=builder /go/bin/pool /bin/
+COPY --from=golangbuilder /go/bin/litd /bin/
+COPY --from=golangbuilder /go/bin/lncli /bin/
+COPY --from=golangbuilder /go/bin/frcli /bin/
+COPY --from=golangbuilder /go/bin/loop /bin/
+COPY --from=golangbuilder /go/bin/pool /bin/
 
 # Add bash.
 RUN apk add --no-cache \

dev.Dockerfile

@@ -1,34 +1,35 @@
-FROM golang:1.15.5-alpine as builder
+# Start with a NodeJS base image that also contains yarn.
+FROM node:12.17.0-alpine as nodejsbuilder
 
 # Copy in the local repository to build from.
 COPY . /go/src/github.com/lightninglabs/lightning-terminal
 
+RUN cd /go/src/github.com/lightninglabs/lightning-terminal/app \
+  && yarn install \
+  && yarn build
+
+# The first stage is already done and all static assets should now be generated
+# in the app/build sub directory.
+FROM golang:1.15.5-alpine as golangbuilder
+
+# Instead of checking out from git again, we just copy the whole working
+# directory of the previous stage that includes the generated static assets.
+COPY --from=nodejsbuilder /go/src/github.com/lightninglabs/lightning-terminal /go/src/github.com/lightninglabs/lightning-terminal
+
 # Force Go to use the cgo based DNS resolver. This is required to ensure DNS
 # queries required to connect to linked containers succeed.
 ENV GODEBUG netdns=cgo
 
 # Explicitly turn on the use of modules (until this becomes the default).
 ENV GO111MODULE on
 
-ENV NODE_VERSION=v12.17.0
-
 # Install dependencies and install/build lightning-terminal.
 RUN apk add --no-cache --update alpine-sdk \
-    git \
     make \
-    curl \
-    bash \
-    binutils \
-    tar \
-&& touch ~/.bashrc \
-&& curl -sfSLO https://unofficial-builds.nodejs.org/download/release/${NODE_VERSION}/node-${NODE_VERSION}-linux-x64-musl.tar.xz \
-&& tar -xf node-${NODE_VERSION}-linux-x64-musl.tar.xz -C /usr --strip 1 \
-&& rm node-${NODE_VERSION}-linux-x64-musl.tar.xz \
-&& curl -o- -L https://yarnpkg.com/install.sh | bash \
-&& . ~/.bashrc \
-&& cd /go/src/github.com/lightninglabs/lightning-terminal \
-&& make install \
-&& make go-install-cli
+  && cd /go/src/github.com/lightninglabs/lightning-terminal \
+  && make statik-only \
+  && make go-install \
+  && make go-install-cli
 
 # Start a new, final image to reduce size.
 FROM alpine as final
@@ -40,11 +41,11 @@ VOLUME /root/.lnd
 EXPOSE 8443 10009 9735
 
 # Copy the binaries and entrypoint from the builder image.
-COPY --from=builder /go/bin/litd /bin/
-COPY --from=builder /go/bin/lncli /bin/
-COPY --from=builder /go/bin/frcli /bin/
-COPY --from=builder /go/bin/loop /bin/
-COPY --from=builder /go/bin/pool /bin/
+COPY --from=golangbuilder /go/bin/litd /bin/
+COPY --from=golangbuilder /go/bin/lncli /bin/
+COPY --from=golangbuilder /go/bin/frcli /bin/
+COPY --from=golangbuilder /go/bin/loop /bin/
+COPY --from=golangbuilder /go/bin/pool /bin/
 
 # Add bash.
 RUN apk add --no-cache \