lnc: add timeout to the inital grpc connection with Mailbox

positiveblue · positiveblue · commit 2e13b87cfb8e · 2024-02-09T18:26:08.000-08:00
Make sure that we do not hold forever if we are not able to dial with
the maiblox service.

This could happen in cases where a passphrase is being reused
and the secret key has already been negotiated for example.
diff --git a/lnc/lnc.go b/lnc/lnc.go
@@ -281,8 +281,12 @@ func (n *NodeConn) newConn(session *Session, opts ...grpc.DialOption) (*conn,
 	}
 	dialOpts = append(dialOpts, opts...)
 
+	ctxt, cancelT := context.WithTimeout(
+		context.Background(), DefaultConnectionTimetout,
+	)
+	defer cancelT()
 	grpcClient, err := grpc.DialContext(
-		ctxc, session.MailboxAddr, dialOpts...,
+		ctxt, session.MailboxAddr, dialOpts...,
 	)
 	if err != nil {
 		cancel()

Original file line number	Diff line number	Diff line change
`@@ -281,8 +281,12 @@ func (n NodeConn) newConn(session Session, opts ...grpc.DialOption) (*conn,`
`281`	`281`	`}`
`282`	`282`	`dialOpts = append(dialOpts, opts...)`
`283`	`283`
	`284`	`+ ctxt, cancelT := context.WithTimeout(`
	`285`	`+ context.Background(), DefaultConnectionTimetout,`
	`286`	`+ )`
	`287`	`+ defer cancelT()`
`284`	`288`	`grpcClient, err := grpc.DialContext(`
`285`		`- ctxc, session.MailboxAddr, dialOpts...,`
	`289`	`+ ctxt, session.MailboxAddr, dialOpts...,`
`286`	`290`	`)`
`287`	`291`	`if err != nil {`
`288`	`292`	`cancel()`