Skip to content

Conversation

@valentinewallace
Copy link
Contributor

Useful for upgrade/downgrade testing in the lightning-tests module, which cannot access internal methods.

Addresses #4240 (comment)

Useful for upgrade/downgrade testing in the lightning-tests module, which
cannot access internal methods.
@ldk-reviews-bot
Copy link

ldk-reviews-bot commented Dec 1, 2025

I've assigned @wpaulino as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

@codecov
Copy link

codecov bot commented Dec 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.31%. Comparing base (3e186bc) to head (aa6a64b).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4253      +/-   ##
==========================================
- Coverage   89.31%   89.31%   -0.01%     
==========================================
  Files         180      180              
  Lines      138966   138969       +3     
  Branches   138966   138969       +3     
==========================================
- Hits       124121   124115       -6     
- Misses      12218    12232      +14     
+ Partials     2627     2622       -5     
Flag Coverage Δ
fuzzing 35.97% <25.00%> (-0.01%) ⬇️
tests 88.67% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ldk-reviews-bot
Copy link

👋 The first review has been submitted!

Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer.

@wpaulino wpaulino merged commit dd127a8 into lightningdevkit:main Dec 1, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants