Skip to content

Commit d0e22fa

Browse files
committed
Consistently use wire::Message for encoding network messages
Previously, `enqueue_message` took an `M: Type + Writeable` reference, which didn't make use of our `wire::Message` type, which turned out to be rather confusing. Here, we use `Message` consistently in `PeerManager`'s `enqueue_message`, but also in `encrypt_message`, etc. While at it we also switch to move semantics, which is a nice cleanup.
1 parent bb5504e commit d0e22fa

File tree

5 files changed

+285
-153
lines changed

5 files changed

+285
-153
lines changed

lightning/src/ln/channelmanager.rs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13872,7 +13872,9 @@ where
1387213872
&MessageSendEvent::UpdateHTLCs { .. } => false,
1387313873
&MessageSendEvent::SendRevokeAndACK { .. } => false,
1387413874
&MessageSendEvent::SendClosingSigned { .. } => false,
13875+
#[cfg(simple_close)]
1387513876
&MessageSendEvent::SendClosingComplete { .. } => false,
13877+
#[cfg(simple_close)]
1387613878
&MessageSendEvent::SendClosingSig { .. } => false,
1387713879
&MessageSendEvent::SendShutdown { .. } => false,
1387813880
&MessageSendEvent::SendChannelReestablish { .. } => false,

lightning/src/ln/functional_test_utils.rs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1124,7 +1124,9 @@ pub fn remove_first_msg_event_to_node(
11241124
MessageSendEvent::UpdateHTLCs { node_id, .. } => node_id == msg_node_id,
11251125
MessageSendEvent::SendRevokeAndACK { node_id, .. } => node_id == msg_node_id,
11261126
MessageSendEvent::SendClosingSigned { node_id, .. } => node_id == msg_node_id,
1127+
#[cfg(simple_close)]
11271128
MessageSendEvent::SendClosingComplete { node_id, .. } => node_id == msg_node_id,
1129+
#[cfg(simple_close)]
11281130
MessageSendEvent::SendClosingSig { node_id, .. } => node_id == msg_node_id,
11291131
MessageSendEvent::SendShutdown { node_id, .. } => node_id == msg_node_id,
11301132
MessageSendEvent::SendChannelReestablish { node_id, .. } => node_id == msg_node_id,

lightning/src/ln/msgs.rs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1857,13 +1857,15 @@ pub enum MessageSendEvent {
18571857
msg: ClosingSigned,
18581858
},
18591859
/// Used to indicate that a `closing_complete` message should be sent to the peer with the given `node_id`.
1860+
#[cfg(simple_close)]
18601861
SendClosingComplete {
18611862
/// The node_id of the node which should receive this message
18621863
node_id: PublicKey,
18631864
/// The message which should be sent.
18641865
msg: ClosingComplete,
18651866
},
18661867
/// Used to indicate that a `closing_sig` message should be sent to the peer with the given `node_id`.
1868+
#[cfg(simple_close)]
18671869
SendClosingSig {
18681870
/// The node_id of the node which should receive this message
18691871
node_id: PublicKey,

lightning/src/ln/peer_channel_encryptor.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -565,12 +565,12 @@ impl PeerChannelEncryptor {
565565
/// Encrypts the given message, returning the encrypted version.
566566
/// panics if the length of `message`, once encoded, is greater than 65535 or if the Noise
567567
/// handshake has not finished.
568-
pub fn encrypt_message<M: wire::Type>(&mut self, message: &M) -> Vec<u8> {
568+
pub fn encrypt_message<T: wire::Type>(&mut self, message: wire::Message<T>) -> Vec<u8> {
569569
// Allocate a buffer with 2KB, fitting most common messages. Reserve the first 16+2 bytes
570570
// for the 2-byte message type prefix and its MAC.
571571
let mut res = VecWriter(Vec::with_capacity(MSG_BUF_ALLOC_SIZE));
572572
res.0.resize(16 + 2, 0);
573-
wire::write(message, &mut res).expect("In-memory messages must never fail to serialize");
573+
wire::write(&message, &mut res).expect("In-memory messages must never fail to serialize");
574574

575575
self.encrypt_message_with_header_0s(&mut res.0);
576576
res.0

0 commit comments

Comments
 (0)