Commit cface29
committed
Deprecate
While its cool to have a super trivial API to initiate payment to
a `HumanReadableName`, most wallets ultimately support multiple
payment instruction formats (eg on-chain) or multiple HRN
resolution schemes (eg LN-Address). Thus, we generally don't expect
this API to get a lot of use.
Meanwhile, we've now ended up with both a
`ChannelManager::pay_for_offer_from_hrn` and
`ChannelManager::pay_for_ofer_from_human_readable_name`, which is
incredibly confusing.
Here, we deprecate `pay_for_offer_from_human_readable_name`,
pushing folks to the `bitcoin-payment-instructions` crate instead.
Because it has outbound payment states associated with it it may be
some time before we can fully remove all the pieces of it, sadly.pay_for_offer_from_human_readable_name
1 parent 07bf08b commit cface29
File tree
2 files changed
+6
-7
lines changed- lightning-dns-resolver/src
- lightning/src/ln
2 files changed
+6
-7
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
388 | 388 | | |
389 | 389 | | |
390 | 390 | | |
| 391 | + | |
391 | 392 | | |
392 | 393 | | |
393 | 394 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
12600 | 12600 | | |
12601 | 12601 | | |
12602 | 12602 | | |
12603 | | - | |
12604 | | - | |
12605 | | - | |
12606 | | - | |
12607 | | - | |
12608 | | - | |
12609 | | - | |
| 12603 | + | |
| 12604 | + | |
| 12605 | + | |
| 12606 | + | |
12610 | 12607 | | |
12611 | 12608 | | |
12612 | 12609 | | |
| |||
12638 | 12635 | | |
12639 | 12636 | | |
12640 | 12637 | | |
| 12638 | + | |
12641 | 12639 | | |
12642 | 12640 | | |
12643 | 12641 | | |
| |||
0 commit comments