Use i64 for LSPS error codes

LSPS doesn't specify what type error codes are, it just makes
reference to JSON-RPC, which only specifies that they are
"integers". In JSON this is also not defined, but probably means
~`i58`s which is the integer range in `f64`s. To ensure we don't
spuriously fail to parse errors, best to just use `i64`s.

Author: TheBlueMatt

lightning-liquidity/src/lsps0/ser.rs

@@ -51,12 +51,12 @@ pub(crate) const JSONRPC_ID_FIELD_KEY: &str = "id";
 pub(crate) const JSONRPC_PARAMS_FIELD_KEY: &str = "params";
 pub(crate) const JSONRPC_RESULT_FIELD_KEY: &str = "result";
 pub(crate) const JSONRPC_ERROR_FIELD_KEY: &str = "error";
-pub(crate) const JSONRPC_INVALID_MESSAGE_ERROR_CODE: i32 = -32700;
+pub(crate) const JSONRPC_INVALID_MESSAGE_ERROR_CODE: i64 = -32700;
 pub(crate) const JSONRPC_INVALID_MESSAGE_ERROR_MESSAGE: &str = "parse error";
-pub(crate) const JSONRPC_INTERNAL_ERROR_ERROR_CODE: i32 = -32603;
+pub(crate) const JSONRPC_INTERNAL_ERROR_ERROR_CODE: i64 = -32603;
 pub(crate) const JSONRPC_INTERNAL_ERROR_ERROR_MESSAGE: &str = "Internal error";
 
-pub(crate) const LSPS0_CLIENT_REJECTED_ERROR_CODE: i32 = 1;
+pub(crate) const LSPS0_CLIENT_REJECTED_ERROR_CODE: i64 = 1;
 
 #[derive(Copy, Clone, Debug, PartialEq, Eq)]
 pub(crate) enum LSPSMethod {
@@ -306,7 +306,7 @@ impl Readable for LSPSDateTime {
 #[derive(Clone, Debug, PartialEq, Eq, Deserialize, Serialize)]
 pub struct LSPSResponseError {
 	/// A number that indicates the error type that occurred.
-	pub code: i32,
+	pub code: i64,
 	/// A string providing a short description of the error.
 	pub message: String,
 	/// A primitive or structured value that contains additional information about the error.

lightning-liquidity/src/lsps1/msgs.rs

@@ -29,9 +29,9 @@ pub(crate) const LSPS1_GET_INFO_METHOD_NAME: &str = "lsps1.get_info";
 pub(crate) const LSPS1_CREATE_ORDER_METHOD_NAME: &str = "lsps1.create_order";
 pub(crate) const LSPS1_GET_ORDER_METHOD_NAME: &str = "lsps1.get_order";
 
-pub(crate) const _LSPS1_CREATE_ORDER_REQUEST_INVALID_PARAMS_ERROR_CODE: i32 = -32602;
+pub(crate) const _LSPS1_CREATE_ORDER_REQUEST_INVALID_PARAMS_ERROR_CODE: i64 = -32602;
 #[cfg(lsps1_service)]
-pub(crate) const LSPS1_CREATE_ORDER_REQUEST_ORDER_MISMATCH_ERROR_CODE: i32 = 100;
+pub(crate) const LSPS1_CREATE_ORDER_REQUEST_ORDER_MISMATCH_ERROR_CODE: i64 = 100;
 
 /// The identifier of an order.
 #[derive(Clone, Debug, PartialEq, Eq, Deserialize, Serialize, Hash)]

lightning-liquidity/src/lsps2/msgs.rs

@@ -33,11 +33,11 @@ use crate::utils;
 pub(crate) const LSPS2_GET_INFO_METHOD_NAME: &str = "lsps2.get_info";
 pub(crate) const LSPS2_BUY_METHOD_NAME: &str = "lsps2.buy";
 
-pub(crate) const LSPS2_GET_INFO_REQUEST_UNRECOGNIZED_OR_STALE_TOKEN_ERROR_CODE: i32 = 200;
+pub(crate) const LSPS2_GET_INFO_REQUEST_UNRECOGNIZED_OR_STALE_TOKEN_ERROR_CODE: i64 = 200;
 
-pub(crate) const LSPS2_BUY_REQUEST_INVALID_OPENING_FEE_PARAMS_ERROR_CODE: i32 = 201;
-pub(crate) const LSPS2_BUY_REQUEST_PAYMENT_SIZE_TOO_SMALL_ERROR_CODE: i32 = 202;
-pub(crate) const LSPS2_BUY_REQUEST_PAYMENT_SIZE_TOO_LARGE_ERROR_CODE: i32 = 203;
+pub(crate) const LSPS2_BUY_REQUEST_INVALID_OPENING_FEE_PARAMS_ERROR_CODE: i64 = 201;
+pub(crate) const LSPS2_BUY_REQUEST_PAYMENT_SIZE_TOO_SMALL_ERROR_CODE: i64 = 202;
+pub(crate) const LSPS2_BUY_REQUEST_PAYMENT_SIZE_TOO_LARGE_ERROR_CODE: i64 = 203;
 
 #[derive(Clone, Debug, PartialEq, Eq, Deserialize, Serialize)]
 /// A request made to an LSP to learn their current channel fees and parameters.

lightning-liquidity/src/lsps5/msgs.rs

@@ -41,23 +41,23 @@ pub const MAX_APP_NAME_LENGTH: usize = 64;
 pub const MAX_WEBHOOK_URL_LENGTH: usize = 1024;
 
 /// Either the app name or the webhook URL is too long.
-pub const LSPS5_TOO_LONG_ERROR_CODE: i32 = 500;
+pub const LSPS5_TOO_LONG_ERROR_CODE: i64 = 500;
 /// The provided URL could not be parsed.
-pub const LSPS5_URL_PARSE_ERROR_CODE: i32 = 501;
+pub const LSPS5_URL_PARSE_ERROR_CODE: i64 = 501;
 /// The provided URL is not HTTPS.
-pub const LSPS5_UNSUPPORTED_PROTOCOL_ERROR_CODE: i32 = 502;
+pub const LSPS5_UNSUPPORTED_PROTOCOL_ERROR_CODE: i64 = 502;
 /// The client has too many webhooks registered.
-pub const LSPS5_TOO_MANY_WEBHOOKS_ERROR_CODE: i32 = 503;
+pub const LSPS5_TOO_MANY_WEBHOOKS_ERROR_CODE: i64 = 503;
 /// The app name was not found.
-pub const LSPS5_APP_NAME_NOT_FOUND_ERROR_CODE: i32 = 1010;
+pub const LSPS5_APP_NAME_NOT_FOUND_ERROR_CODE: i64 = 1010;
 /// An unknown error occurred.
-pub const LSPS5_UNKNOWN_ERROR_CODE: i32 = 1000;
+pub const LSPS5_UNKNOWN_ERROR_CODE: i64 = 1000;
 /// An error occurred during serialization of LSPS5 webhook notification.
-pub const LSPS5_SERIALIZATION_ERROR_CODE: i32 = 1001;
+pub const LSPS5_SERIALIZATION_ERROR_CODE: i64 = 1001;
 /// A notification was sent too frequently.
-pub const LSPS5_SLOW_DOWN_ERROR_CODE: i32 = 1002;
+pub const LSPS5_SLOW_DOWN_ERROR_CODE: i64 = 1002;
 /// A request was rejected because the client has no prior activity with the LSP (no open channel and no active LSPS1 or LSPS2 flow). The client should first open a channel
-pub const LSPS5_NO_PRIOR_ACTIVITY_ERROR_CODE: i32 = 1003;
+pub const LSPS5_NO_PRIOR_ACTIVITY_ERROR_CODE: i64 = 1003;
 
 pub(crate) const LSPS5_SET_WEBHOOK_METHOD_NAME: &str = "lsps5.set_webhook";
 pub(crate) const LSPS5_LIST_WEBHOOKS_METHOD_NAME: &str = "lsps5.list_webhooks";
@@ -126,7 +126,7 @@ pub enum LSPS5ProtocolError {
 
 impl LSPS5ProtocolError {
 	/// The error code for the LSPS5 protocol error.
-	pub fn code(&self) -> i32 {
+	pub fn code(&self) -> i64 {
 		match self {
 			LSPS5ProtocolError::AppNameTooLong | LSPS5ProtocolError::WebhookUrlTooLong => {
 				LSPS5_TOO_LONG_ERROR_CODE
@@ -197,9 +197,9 @@ pub enum LSPS5ClientError {
 }
 
 impl LSPS5ClientError {
-	const BASE: i32 = 100_000;
+	const BASE: i64 = 100_000;
 	/// The error code for the client error.
-	pub fn code(&self) -> i32 {
+	pub fn code(&self) -> i64 {
 		use LSPS5ClientError::*;
 		match self {
 			InvalidSignature => Self::BASE + 1,