accounts/usbwallet: fix double hashing in SignTextWithPassphrase (ethereum#33138)

lucia-w · fjl · commit 32bc4fc59116 · 2025-11-28T15:08:10.000+01:00
SignTextWithPassphrase calls SignText, which already performs TextHash.
diff --git a/accounts/usbwallet/wallet.go b/accounts/usbwallet/wallet.go
@@ -632,7 +632,7 @@ func (w *wallet) SignTx(account accounts.Account, tx *types.Transaction, chainID
 // data is not supported for Ledger wallets, so this method will always return
 // an error.
 func (w *wallet) SignTextWithPassphrase(account accounts.Account, passphrase string, text []byte) ([]byte, error) {
-	return w.SignText(account, accounts.TextHash(text))
+	return w.SignText(account, text)
 }
 
 // SignTxWithPassphrase implements accounts.Wallet, attempting to sign the given

Original file line number	Diff line number	Diff line change
`@@ -632,7 +632,7 @@ func (w wallet) SignTx(account accounts.Account, tx types.Transaction, chainID`
`632`	`632`	`// data is not supported for Ledger wallets, so this method will always return`
`633`	`633`	`// an error.`
`634`	`634`	`func (w *wallet) SignTextWithPassphrase(account accounts.Account, passphrase string, text []byte) ([]byte, error) {`
`635`		`- return w.SignText(account, accounts.TextHash(text))`
	`635`	`+ return w.SignText(account, text)`
`636`	`636`	`}`
`637`	`637`
`638`	`638`	`// SignTxWithPassphrase implements accounts.Wallet, attempting to sign the given`