Fix code quality issues and improve portability

Author: alienx5499

src/security/tls/tls_details.cpp

@@ -165,9 +165,9 @@ namespace libp2p::security::tls_details {
       constexpr size_t prefix_size = sign_prefix.size();
       size_t msg_len = prefix_size + cert_pub_key.size();
 
-      uint8_t buf[msg_len];  // NOLINT
-      memcpy(buf, sign_prefix.data(), sign_prefix.size());
-      memcpy(buf + sign_prefix.size(),  // NOLINT
+      std::vector<uint8_t> buf(msg_len);
+      memcpy(buf.data(), sign_prefix.data(), sign_prefix.size());
+      memcpy(buf.data() + sign_prefix.size(),
              cert_pub_key.data(),
              cert_pub_key.size());
 
@@ -203,8 +203,8 @@ namespace libp2p::security::tls_details {
     void assignSerial(X509 *cert) {
       BIGNUM *bn = BN_new();
       CLEANUP_PTR(bn, BN_free);
-      if (BN_pseudo_rand(bn, 64, 0, 0) == 0) {
-        throw std::runtime_error("BN_pseudo_rand failed");
+      if (BN_rand(bn, 64, 0, 0) == 0) {
+        throw std::runtime_error("BN_rand failed");
       }
 
       ASN1_INTEGER *rand_int = ASN1_INTEGER_new();
@@ -402,13 +402,13 @@ namespace libp2p::security::tls_details {
       constexpr size_t prefix_size = sign_prefix.size();
 
       size_t msg_len = prefix_size + len;
-      uint8_t buf[msg_len];  // NOLINT
-      memcpy(buf, sign_prefix.data(), prefix_size);
-      uint8_t *b = buf + prefix_size;  // NOLINT
+      std::vector<uint8_t> buf(msg_len);
+      memcpy(buf.data(), sign_prefix.data(), prefix_size);
+      uint8_t *b = buf.data() + prefix_size;
       i2d_PUBKEY(cert_pubkey, &b);
 
       auto verify_res = crypto::ed25519::Ed25519ProviderImpl{}.verify(
-          BytesIn(buf, buf + msg_len),  // NOLINT
+          BytesIn(buf.data(), buf.data() + msg_len),
           signature,
           ed25519pkey);
 

src/transport/tcp/tcp_transport.cpp

@@ -21,8 +21,7 @@ namespace libp2p::transport {
     auto &[info, layers] = r.value();
     auto conn = std::make_shared<TcpConnection>(*context_, layers);
     auto connect =
-        [=,
-         self{shared_from_this()},
+        [self{shared_from_this()},
          handler{std::move(handler)},
          layers = std::move(layers)](
             outcome::result<boost::asio::ip::tcp::resolver::results_type>