How do I make a checked or disabled menu item?

[pharan]

In Windows.
I'm trying to make a context menu with disabled items and items with a checkmark.

  Widget testTextWithContextMenu({
    bool checked = true,
  }) {
    return GestureDetector(
      onSecondaryTap: () {
        final menu = Menu();

        final checkableItem = MenuItem("Checkable", MenuItemType.checkbox);
        checkableItem.state = checked
            ? MenuItemState.checked
            : MenuItemState.unchecked;

        final disabledItem = MenuItem("Disabled");
        disabledItem.enabled = false;

        menu.addItem(checkableItem);
        menu.addItem(disabledItem);

        menu.open(PositioningStrategy.cursorPosition());
      },
      child: Text("Right-click on me"),
    );
  }

I pass the default argument checked: true.

When I right-click on the text, the menu appears but...

There is no checkmark on the "Checkable" menu item.
And the "Disabled" menu item is not disabled.

[lijy91]

Hey @pharan,

The issue is that on Windows, state and enabled need to be set after adding the item to the menu. Here's the fix for your code:

Widget testTextWithContextMenu({
    bool checked = true,
  }) {
    return GestureDetector(
      onSecondaryTap: () {
        final menu = Menu();

        final checkableItem = MenuItem("Checkable", MenuItemType.checkbox);
        final disabledItem = MenuItem("Disabled");

        menu.addItem(checkableItem);
        menu.addItem(disabledItem);

        // 👇 Set state and enabled AFTER addItem
        checkableItem.state = checked
            ? MenuItemState.checked
            : MenuItemState.unchecked;
        disabledItem.enabled = false;

        menu.open(PositioningStrategy.cursorPosition());
      },
      child: Text("Right-click on me"),
    );
  }

Just move the property assignments after addItem() and it should work on Windows.

We'll also fix the underlying issue in the Windows native implementation so that setting these properties before addItem() works as expected in a future release.

[lijy91]

The root cause has been documented in detail in issue #5, and a fix has been applied in the Windows native code.