Skip to content

Commit a9f2487

Browse files
committed
🔥 the old API.
1 parent 7864132 commit a9f2487

File tree

2 files changed

+3
-23
lines changed

2 files changed

+3
-23
lines changed

ObjectiveGit/GTReference.h

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -59,9 +59,6 @@ typedef NS_OPTIONS(NSInteger, GTReferenceType) {
5959
@property (nonatomic, readonly, strong) GTReflog *reflog;
6060

6161
/// Convenience initializers
62-
+ (id)referenceByLookingUpReferencedNamed:(NSString *)refName inRepository:(GTRepository *)theRepo error:(NSError **)error;
63-
- (id)initByLookingUpReferenceNamed:(NSString *)refName inRepository:(GTRepository *)theRepo error:(NSError **)error;
64-
6562
+ (id)referenceByResolvingSymbolicReference:(GTReference *)symbolicRef error:(NSError **)error;
6663
- (id)initByResolvingSymbolicReference:(GTReference *)symbolicRef error:(NSError **)error;
6764

ObjectiveGit/GTReference.m

Lines changed: 3 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@
3232
#import "GTSignature.h"
3333
#import "NSError+Git.h"
3434
#import "NSString+Git.h"
35+
#import "GTRepository+References.h"
3536

3637
#import "git2/errors.h"
3738

@@ -69,28 +70,10 @@ - (BOOL)isRemote {
6970
return git_reference_is_remote(self.git_reference) != 0;
7071
}
7172

72-
+ (id)referenceByLookingUpReferencedNamed:(NSString *)refName inRepository:(GTRepository *)theRepo error:(NSError **)error {
73-
return [[self alloc] initByLookingUpReferenceNamed:refName inRepository:theRepo error:error];
74-
}
75-
7673
+ (id)referenceByResolvingSymbolicReference:(GTReference *)symbolicRef error:(NSError **)error {
7774
return [[self alloc] initByResolvingSymbolicReference:symbolicRef error:error];
7875
}
7976

80-
- (id)initByLookingUpReferenceNamed:(NSString *)refName inRepository:(GTRepository *)repo error:(NSError **)error {
81-
NSParameterAssert(refName != nil);
82-
NSParameterAssert(repo != nil);
83-
84-
git_reference *ref = NULL;
85-
int gitError = git_reference_lookup(&ref, repo.git_repository, refName.UTF8String);
86-
if (gitError != GIT_OK) {
87-
if (error != NULL) *error = [NSError git_errorFor:gitError description:@"Failed to lookup reference %@.", refName];
88-
return nil;
89-
}
90-
91-
return [self initWithGitReference:ref repository:repo];
92-
}
93-
9477
- (id)initByResolvingSymbolicReference:(GTReference *)symbolicRef error:(NSError **)error {
9578
NSParameterAssert(symbolicRef != nil);
9679

@@ -151,7 +134,7 @@ - (id)unresolvedTarget {
151134
NSString *refName = @(git_reference_symbolic_target(self.git_reference));
152135
if (refName == NULL) return nil;
153136

154-
return [self.class referenceByLookingUpReferencedNamed:refName inRepository:self.repository error:NULL];
137+
return [self.repository lookUpReferenceWithName:refName error:NULL];
155138
}
156139
return nil;
157140
}
@@ -221,7 +204,7 @@ - (GTOID *)OID {
221204
}
222205

223206
- (GTReference *)reloadedReferenceWithError:(NSError **)error {
224-
return [[self.class alloc] initByLookingUpReferenceNamed:self.name inRepository:self.repository error:error];
207+
return [self.repository lookUpReferenceWithName:self.name error:error];
225208
}
226209

227210
+ (NSError *)invalidReferenceError {

0 commit comments

Comments
 (0)