Set GIT_REPOSITORY_INIT_MKPATH by default

Author: jspahrsummers

ObjectiveGit/GTRepository.m

@@ -128,7 +128,6 @@ + (instancetype)initializeEmptyRepositoryAtFileURL:(NSURL *)localFileURL options
 	}
 
 	git_repository_init_options options = GIT_REPOSITORY_INIT_OPTIONS_INIT;
-	options.flags = (uint32_t)[optionsDict[GTRepositoryInitOptionsFlags] unsignedIntegerValue];
 	options.mode = (uint32_t)
 	[optionsDict[GTRepositoryInitOptionsMode] unsignedIntegerValue];
 	options.workdir_path = [optionsDict[GTRepositoryInitWorkingDirectoryPath] UTF8String];
@@ -137,6 +136,10 @@ + (instancetype)initializeEmptyRepositoryAtFileURL:(NSURL *)localFileURL options
 	options.initial_head = [optionsDict[GTRepositoryInitInitialHEAD] UTF8String];
 	options.origin_url = [optionsDict[GTRepositoryInitOriginURLString] UTF8String];
 
+	// This default mirrors git_repository_init().
+	NSNumber *flags = optionsDict[GTRepositoryInitOptionsFlags];
+	options.flags = (flags == nil ? GIT_REPOSITORY_INIT_MKPATH : (uint32_t)flags.unsignedIntegerValue);
+
 	const char *path = localFileURL.path.fileSystemRepresentation;
 	git_repository *repository = NULL;
 	int gitError = git_repository_init_ext(&repository, path, &options);

ObjectiveGitTests/GTRepositorySpec.m

@@ -25,8 +25,11 @@
 	it(@"should initialize a repository with a working directory by default", ^{
 		NSURL *newRepoURL = [self.tempDirectoryFileURL URLByAppendingPathComponent:@"init-repo"];
 
-		GTRepository *repository = [GTRepository initializeEmptyRepositoryAtFileURL:newRepoURL options:nil error:NULL];
+		NSError *error;
+		GTRepository *repository = [GTRepository initializeEmptyRepositoryAtFileURL:newRepoURL options:nil error:&error];
 		expect(repository).notTo(beNil());
+		expect(error).to(beNil());
+		
 		expect(repository.gitDirectoryURL).notTo(beNil());
 		expect(@(repository.bare)).to(beFalsy());
 	});
@@ -37,8 +40,11 @@
 			GTRepositoryInitOptionsFlags: @(GTRepositoryInitBare)
 		};
 
-		GTRepository *repository = [GTRepository initializeEmptyRepositoryAtFileURL:newRepoURL options:options error:NULL];
+		NSError *error;
+		GTRepository *repository = [GTRepository initializeEmptyRepositoryAtFileURL:newRepoURL options:options error:&error];
 		expect(repository).notTo(beNil());
+		expect(error).to(beNil());
+		
 		expect(repository.gitDirectoryURL).notTo(beNil());
 		expect(@(repository.bare)).to(beTruthy());
 	});
@@ -203,6 +209,7 @@
 		NSError *error = nil;
 		NSURL *fileURL = [self.tempDirectoryFileURL URLByAppendingPathComponent:@"newrepo"];
 		GTRepository *newRepo = [GTRepository initializeEmptyRepositoryAtFileURL:fileURL options:nil error:&error];
+		expect(newRepo).notTo(beNil());
 		expect(@(newRepo.isEmpty)).to(beTruthy());
 		[NSFileManager.defaultManager removeItemAtURL:fileURL error:NULL];
 	});