Remove git protocol from test data

bording · bording · commit 6490ff1e5787 · 2022-04-01T16:43:20.000-04:00
diff --git a/LibGit2Sharp.Tests/CloneFixture.cs b/LibGit2Sharp.Tests/CloneFixture.cs
@@ -13,8 +13,6 @@ public class CloneFixture : BaseFixture
         [Theory]
         [InlineData("http://github.com/libgit2/TestGitRepository")]
         [InlineData("https://github.com/libgit2/TestGitRepository")]
-        [InlineData("git://github.com/libgit2/TestGitRepository")]
-        //[InlineData("git@github.com:libgit2/TestGitRepository")]
         public void CanClone(string url)
         {
             var scd = BuildSelfCleaningDirectory();
@@ -102,8 +100,6 @@ public void CanCloneALocalRepositoryFromANewlyCreatedTemporaryPath()
         [Theory]
         [InlineData("http://github.com/libgit2/TestGitRepository")]
         [InlineData("https://github.com/libgit2/TestGitRepository")]
-        [InlineData("git://github.com/libgit2/TestGitRepository")]
-        //[InlineData("git@github.com:libgit2/TestGitRepository")]
         public void CanCloneBarely(string url)
         {
             var scd = BuildSelfCleaningDirectory();
@@ -126,7 +122,7 @@ public void CanCloneBarely(string url)
         }
 
         [Theory]
-        [InlineData("git://github.com/libgit2/TestGitRepository")]
+        [InlineData("https://github.com/libgit2/TestGitRepository")]
         public void WontCheckoutIfAskedNotTo(string url)
         {
             var scd = BuildSelfCleaningDirectory();
@@ -143,7 +139,7 @@ public void WontCheckoutIfAskedNotTo(string url)
         }
 
         [Theory]
-        [InlineData("git://github.com/libgit2/TestGitRepository")]
+        [InlineData("https://github.com/libgit2/TestGitRepository")]
         public void CallsProgressCallbacks(string url)
         {
             bool transferWasCalled = false;
@@ -301,7 +297,7 @@ public void CanInspectCertificateOnClone(string url, string hostname, Type certT
         }
 
         [Theory]
-        [InlineData("git://github.com/libgit2/TestGitRepository")]
+        [InlineData("https://github.com/libgit2/TestGitRepository")]
         public void CloningWithoutWorkdirPathThrows(string url)
         {
             Assert.Throws<ArgumentNullException>(() => Repository.Clone(url, null));
diff --git a/LibGit2Sharp.Tests/FetchFixture.cs b/LibGit2Sharp.Tests/FetchFixture.cs
@@ -4,7 +4,6 @@
 using System.Linq;
 using LibGit2Sharp.Tests.TestHelpers;
 using Xunit;
-using Xunit.Extensions;
 
 namespace LibGit2Sharp.Tests
 {
@@ -15,7 +14,6 @@ public class FetchFixture : BaseFixture
         [Theory]
         [InlineData("http://github.com/libgit2/TestGitRepository")]
         [InlineData("https://github.com/libgit2/TestGitRepository")]
-        [InlineData("git://github.com/libgit2/TestGitRepository.git")]
         public void CanFetchIntoAnEmptyRepository(string url)
         {
             string path = InitNewRepository();
@@ -74,7 +72,6 @@ public void CanFetchIntoAnEmptyRepositoryWithCredentials()
         [Theory]
         [InlineData("http://github.com/libgit2/TestGitRepository")]
         [InlineData("https://github.com/libgit2/TestGitRepository")]
-        [InlineData("git://github.com/libgit2/TestGitRepository.git")]
         public void CanFetchAllTagsIntoAnEmptyRepository(string url)
         {
             string path = InitNewRepository();
@@ -101,7 +98,8 @@ public void CanFetchAllTagsIntoAnEmptyRepository(string url)
                 }
 
                 // Perform the actual fetch
-                Commands.Fetch(repo, remoteName, new string[0], new FetchOptions {
+                Commands.Fetch(repo, remoteName, new string[0], new FetchOptions
+                {
                     TagFetchMode = TagFetchMode.All,
                     OnUpdateTips = expectedFetchState.RemoteUpdateTipsHandler
                 }, null);
@@ -117,7 +115,6 @@ public void CanFetchAllTagsIntoAnEmptyRepository(string url)
         [Theory]
         [InlineData("http://github.com/libgit2/TestGitRepository", "test-branch", "master")]
         [InlineData("https://github.com/libgit2/TestGitRepository", "master", "master")]
-        [InlineData("git://github.com/libgit2/TestGitRepository.git", "master", "first-merge")]
         public void CanFetchCustomRefSpecsIntoAnEmptyRepository(string url, string localBranchName, string remoteBranchName)
         {
             string path = InitNewRepository();
@@ -147,7 +144,8 @@ public void CanFetchCustomRefSpecsIntoAnEmptyRepository(string url, string local
                 }
 
                 // Perform the actual fetch
-                Commands.Fetch(repo, remoteName, new string[] { refSpec }, new FetchOptions {
+                Commands.Fetch(repo, remoteName, new string[] { refSpec }, new FetchOptions
+                {
                     TagFetchMode = TagFetchMode.None,
                     OnUpdateTips = expectedFetchState.RemoteUpdateTipsHandler
                 }, null);
diff --git a/LibGit2Sharp.Tests/NetworkFixture.cs b/LibGit2Sharp.Tests/NetworkFixture.cs
@@ -3,7 +3,6 @@
 using System.Linq;
 using LibGit2Sharp.Tests.TestHelpers;
 using Xunit;
-using Xunit.Extensions;
 
 namespace LibGit2Sharp.Tests
 {
@@ -12,7 +11,6 @@ public class NetworkFixture : BaseFixture
         [Theory]
         [InlineData("http://github.com/libgit2/TestGitRepository")]
         [InlineData("https://github.com/libgit2/TestGitRepository")]
-        [InlineData("git://github.com/libgit2/TestGitRepository.git")]
         public void CanListRemoteReferences(string url)
         {
             string remoteName = "testRemote";
@@ -49,7 +47,6 @@ public void CanListRemoteReferences(string url)
         [Theory]
         [InlineData("http://github.com/libgit2/TestGitRepository")]
         [InlineData("https://github.com/libgit2/TestGitRepository")]
-        [InlineData("git://github.com/libgit2/TestGitRepository.git")]
         public void CanListRemoteReferencesFromUrl(string url)
         {
             string repoPath = InitNewRepository();
@@ -94,9 +91,9 @@ public void CanListRemoteReferenceObjects()
                 Remote remote = repo.Network.Remotes[remoteName];
                 IEnumerable<Reference> references = repo.Network.ListReferences(remote).ToList();
 
-                var actualRefs = new List<Tuple<string,string>>();
+                var actualRefs = new List<Tuple<string, string>>();
 
-                foreach(Reference reference in references)
+                foreach (Reference reference in references)
                 {
                     Assert.NotNull(reference.CanonicalName);
 
@@ -166,7 +163,7 @@ public void CanPull(FastForwardStrategy fastForwardStrategy)
 
                 MergeResult mergeResult = Commands.Pull(repo, Constants.Signature, pullOptions);
 
-                if(fastForwardStrategy == FastForwardStrategy.Default || fastForwardStrategy == FastForwardStrategy.FastForwardOnly)
+                if (fastForwardStrategy == FastForwardStrategy.Default || fastForwardStrategy == FastForwardStrategy.FastForwardOnly)
                 {
                     Assert.Equal(MergeStatus.FastForward, mergeResult.Status);
                     Assert.Equal(mergeResult.Commit, repo.Branches["refs/remotes/origin/master"].Tip);
@@ -226,7 +223,7 @@ public void PullWithoutMergeBranchThrows()
                 {
                     Commands.Pull(repo, Constants.Signature, new PullOptions());
                 }
-                catch(MergeFetchHeadNotFoundException ex)
+                catch (MergeFetchHeadNotFoundException ex)
                 {
                     didPullThrow = true;
                     thrownException = ex;
@@ -293,7 +290,7 @@ public void CanPruneRefs()
                 Assert.NotNull(repo.Refs["refs/remotes/pruner/master"]);
 
                 // but we do when asked by the user
-                Commands.Fetch(repo, "pruner", new string[0], new FetchOptions { Prune = true}, null);
+                Commands.Fetch(repo, "pruner", new string[0], new FetchOptions { Prune = true }, null);
                 Assert.Null(repo.Refs["refs/remotes/pruner/master"]);
             }
         }
diff --git a/LibGit2Sharp.Tests/RepositoryFixture.cs b/LibGit2Sharp.Tests/RepositoryFixture.cs
@@ -4,7 +4,6 @@
 using System.Linq;
 using LibGit2Sharp.Tests.TestHelpers;
 using Xunit;
-using Xunit.Extensions;
 
 namespace LibGit2Sharp.Tests
 {
@@ -709,7 +708,6 @@ public void CanListRemoteReferencesWithCredentials()
         [Theory]
         [InlineData("http://github.com/libgit2/TestGitRepository")]
         [InlineData("https://github.com/libgit2/TestGitRepository")]
-        [InlineData("git://github.com/libgit2/TestGitRepository.git")]
         public void CanListRemoteReferences(string url)
         {
             IEnumerable<Reference> references = Repository.ListRemoteReferences(url).ToList();

Original file line number	Diff line number	Diff line change
`@@ -13,8 +13,6 @@ public class CloneFixture : BaseFixture`
`13`	`13`	`[Theory]`
`14`	`14`	`[InlineData("http://github.com/libgit2/TestGitRepository")]`
`15`	`15`	`[InlineData("https://github.com/libgit2/TestGitRepository")]`
`16`		`- [InlineData("git://github.com/libgit2/TestGitRepository")]`
`17`		`- //[InlineData("git@github.com:libgit2/TestGitRepository")]`
`18`	`16`	`public void CanClone(string url)`
`19`	`17`	`{`
`20`	`18`	`var scd = BuildSelfCleaningDirectory();`
`@@ -102,8 +100,6 @@ public void CanCloneALocalRepositoryFromANewlyCreatedTemporaryPath()`
`102`	`100`	`[Theory]`
`103`	`101`	`[InlineData("http://github.com/libgit2/TestGitRepository")]`
`104`	`102`	`[InlineData("https://github.com/libgit2/TestGitRepository")]`
`105`		`- [InlineData("git://github.com/libgit2/TestGitRepository")]`
`106`		`- //[InlineData("git@github.com:libgit2/TestGitRepository")]`
`107`	`103`	`public void CanCloneBarely(string url)`
`108`	`104`	`{`
`109`	`105`	`var scd = BuildSelfCleaningDirectory();`
`@@ -126,7 +122,7 @@ public void CanCloneBarely(string url)`
`126`	`122`	`}`
`127`	`123`
`128`	`124`	`[Theory]`
`129`		`- [InlineData("git://github.com/libgit2/TestGitRepository")]`
	`125`	`+ [InlineData("https://github.com/libgit2/TestGitRepository")]`
`130`	`126`	`public void WontCheckoutIfAskedNotTo(string url)`
`131`	`127`	`{`
`132`	`128`	`var scd = BuildSelfCleaningDirectory();`
`@@ -143,7 +139,7 @@ public void WontCheckoutIfAskedNotTo(string url)`
`143`	`139`	`}`
`144`	`140`
`145`	`141`	`[Theory]`
`146`		`- [InlineData("git://github.com/libgit2/TestGitRepository")]`
	`142`	`+ [InlineData("https://github.com/libgit2/TestGitRepository")]`
`147`	`143`	`public void CallsProgressCallbacks(string url)`
`148`	`144`	`{`
`149`	`145`	`bool transferWasCalled = false;`
`@@ -301,7 +297,7 @@ public void CanInspectCertificateOnClone(string url, string hostname, Type certT`
`301`	`297`	`}`
`302`	`298`
`303`	`299`	`[Theory]`
`304`		`- [InlineData("git://github.com/libgit2/TestGitRepository")]`
	`300`	`+ [InlineData("https://github.com/libgit2/TestGitRepository")]`
`305`	`301`	`public void CloningWithoutWorkdirPathThrows(string url)`
`306`	`302`	`{`
`307`	`303`	`Assert.Throws<ArgumentNullException>(() => Repository.Clone(url, null));`
Original file line number	Diff line number	Diff line change
`@@ -3,7 +3,6 @@`
`3`	`3`	`using System.Linq;`
`4`	`4`	`using LibGit2Sharp.Tests.TestHelpers;`
`5`	`5`	`using Xunit;`
`6`		`-using Xunit.Extensions;`
`7`	`6`
`8`	`7`	`namespace LibGit2Sharp.Tests`
`9`	`8`	`{`
`@@ -12,7 +11,6 @@ public class NetworkFixture : BaseFixture`
`12`	`11`	`[Theory]`
`13`	`12`	`[InlineData("http://github.com/libgit2/TestGitRepository")]`
`14`	`13`	`[InlineData("https://github.com/libgit2/TestGitRepository")]`
`15`		`- [InlineData("git://github.com/libgit2/TestGitRepository.git")]`
`16`	`14`	`public void CanListRemoteReferences(string url)`
`17`	`15`	`{`
`18`	`16`	`string remoteName = "testRemote";`
`@@ -49,7 +47,6 @@ public void CanListRemoteReferences(string url)`
`49`	`47`	`[Theory]`
`50`	`48`	`[InlineData("http://github.com/libgit2/TestGitRepository")]`
`51`	`49`	`[InlineData("https://github.com/libgit2/TestGitRepository")]`
`52`		`- [InlineData("git://github.com/libgit2/TestGitRepository.git")]`
`53`	`50`	`public void CanListRemoteReferencesFromUrl(string url)`
`54`	`51`	`{`
`55`	`52`	`string repoPath = InitNewRepository();`
`@@ -94,9 +91,9 @@ public void CanListRemoteReferenceObjects()`
`94`	`91`	`Remote remote = repo.Network.Remotes[remoteName];`
`95`	`92`	`IEnumerable<Reference> references = repo.Network.ListReferences(remote).ToList();`
`96`	`93`
`97`		`- var actualRefs = new List<Tuple<string,string>>();`
	`94`	`+ var actualRefs = new List<Tuple<string, string>>();`
`98`	`95`
`99`		`- foreach(Reference reference in references)`
	`96`	`+ foreach (Reference reference in references)`
`100`	`97`	`{`
`101`	`98`	`Assert.NotNull(reference.CanonicalName);`
`102`	`99`
`@@ -166,7 +163,7 @@ public void CanPull(FastForwardStrategy fastForwardStrategy)`
`166`	`163`
`167`	`164`	`MergeResult mergeResult = Commands.Pull(repo, Constants.Signature, pullOptions);`
`168`	`165`
`169`		`- if(fastForwardStrategy == FastForwardStrategy.Default \|\| fastForwardStrategy == FastForwardStrategy.FastForwardOnly)`
	`166`	`+ if (fastForwardStrategy == FastForwardStrategy.Default \|\| fastForwardStrategy == FastForwardStrategy.FastForwardOnly)`
`170`	`167`	`{`
`171`	`168`	`Assert.Equal(MergeStatus.FastForward, mergeResult.Status);`
`172`	`169`	`Assert.Equal(mergeResult.Commit, repo.Branches["refs/remotes/origin/master"].Tip);`
`@@ -226,7 +223,7 @@ public void PullWithoutMergeBranchThrows()`
`226`	`223`	`{`
`227`	`224`	`Commands.Pull(repo, Constants.Signature, new PullOptions());`
`228`	`225`	`}`
`229`		`- catch(MergeFetchHeadNotFoundException ex)`
	`226`	`+ catch (MergeFetchHeadNotFoundException ex)`
`230`	`227`	`{`
`231`	`228`	`didPullThrow = true;`
`232`	`229`	`thrownException = ex;`
`@@ -293,7 +290,7 @@ public void CanPruneRefs()`
`293`	`290`	`Assert.NotNull(repo.Refs["refs/remotes/pruner/master"]);`
`294`	`291`
`295`	`292`	`// but we do when asked by the user`
`296`		`- Commands.Fetch(repo, "pruner", new string[0], new FetchOptions { Prune = true}, null);`
	`293`	`+ Commands.Fetch(repo, "pruner", new string[0], new FetchOptions { Prune = true }, null);`
`297`	`294`	`Assert.Null(repo.Refs["refs/remotes/pruner/master"]);`
`298`	`295`	`}`
`299`	`296`	`}`
Original file line number	Diff line number	Diff line change
`@@ -4,7 +4,6 @@`
`4`	`4`	`using System.Linq;`
`5`	`5`	`using LibGit2Sharp.Tests.TestHelpers;`
`6`	`6`	`using Xunit;`
`7`		`-using Xunit.Extensions;`
`8`	`7`
`9`	`8`	`namespace LibGit2Sharp.Tests`
`10`	`9`	`{`
`@@ -709,7 +708,6 @@ public void CanListRemoteReferencesWithCredentials()`
`709`	`708`	`[Theory]`
`710`	`709`	`[InlineData("http://github.com/libgit2/TestGitRepository")]`
`711`	`710`	`[InlineData("https://github.com/libgit2/TestGitRepository")]`
`712`		`- [InlineData("git://github.com/libgit2/TestGitRepository.git")]`
`713`	`711`	`public void CanListRemoteReferences(string url)`
`714`	`712`	`{`
`715`	`713`	`IEnumerable<Reference> references = Repository.ListRemoteReferences(url).ToList();`