From c71eea8e68a6596830f0c8bfc5677ea0d2f4391c Mon Sep 17 00:00:00 2001 From: Abhinav Agarwal Date: Wed, 20 May 2026 23:36:22 -0700 Subject: [PATCH] fix null-deref warning in tokenize_on_space and promote strict-warnings to required --- .github/workflows/build-ubuntu.yml | 1 - sshfs.c | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/build-ubuntu.yml b/.github/workflows/build-ubuntu.yml index a99d93e2..58800bc4 100644 --- a/.github/workflows/build-ubuntu.yml +++ b/.github/workflows/build-ubuntu.yml @@ -102,7 +102,6 @@ jobs: name: ${{ matrix.compiler }} / strict warnings runs-on: ubuntu-24.04 timeout-minutes: 20 - continue-on-error: true strategy: fail-fast: false matrix: diff --git a/sshfs.c b/sshfs.c index f84b6f29..1bb83c76 100644 --- a/sshfs.c +++ b/sshfs.c @@ -3954,7 +3954,7 @@ static char *tokenize_on_space(char *str) start = pos; - while (pos && *pos != '\0') { + while (*pos != '\0') { // break on space, but not on '\ ' if (*pos == ' ' && *(pos - 1) != '\\') { break;