Ignore comments (#62)

Author: thewilkybarkid

phpstan.neon.dist

@@ -1,7 +1,6 @@
 parameters:
     ignoreErrors:
         - '~^Call to an undefined method FluentDOM\\DOM\\Node\\.+?::getNodePath\(\)\.$~'
-        - '~^Cannot cast FluentDOM\\DOM\\Node\\.+? to string\.$~'
         - '~^Cannot call method (end|([a-z]+)Node)\(\) on Symfony\\Component\\Config\\Definition\\Builder\\NodeParentInterface\|null\.$~'
         - '~^Service "csa_guzzle\.mock\.storage" is not registered in the container\.$~'
     level: max

vendor-extra/LiberoPageBundle/tests/XmlTestCase.php

@@ -7,6 +7,7 @@
 use FluentDOM;
 use FluentDOM\DOM\Document;
 use FluentDOM\DOM\Element;
+use FluentDOM\DOM\Node\NonDocumentTypeChildNode;
 
 trait XmlTestCase
 {
@@ -23,4 +24,9 @@ final protected function loadElement(string $xml) : Element
     {
         return $this->loadDocument($xml)->documentElement;
     }
+
+    final protected function loadNode(string $xml) : NonDocumentTypeChildNode
+    {
+        return $this->loadElement("<root>$xml</root>")[0];
+    }
 }

vendor-extra/ViewsBundle/src/Views/EventDispatchingViewConverter.php

@@ -4,8 +4,10 @@
 
 namespace Libero\ViewsBundle\Views;
 
+use FluentDOM\DOM\CdataSection;
 use FluentDOM\DOM\Element;
 use FluentDOM\DOM\Node\NonDocumentTypeChildNode;
+use FluentDOM\DOM\Text;
 use Libero\ViewsBundle\Event\BuildViewEvent;
 use LogicException;
 use Symfony\Component\EventDispatcher\EventDispatcherInterface;
@@ -29,6 +31,10 @@ public function convert(NonDocumentTypeChildNode $node, ?string $template = null
                 );
             }
 
+            if (!$node instanceof Text && !$node instanceof CdataSection) {
+                return new View('@LiberoPatterns/text.html.twig', ['nodes' => ''], $context);
+            }
+
             return new View('@LiberoPatterns/text.html.twig', ['nodes' => (string) $node], $context);
         }
 

vendor-extra/ViewsBundle/tests/Views/EventDispatchingViewConverterTest.php

@@ -46,6 +46,29 @@ public function it_returns_text_by_default() : void
         $this->assertEquals($expected, $handler->convert($node));
     }
 
+    /**
+     * @test
+     * @dataProvider nonElementProvider
+     */
+    public function it_handles_non_elements(string $node, $expected = '') : void
+    {
+        $handler = new EventDispatchingViewConverter(new EventDispatcher());
+
+        $node = $this->loadNode($node);
+
+        $expected = new View('@LiberoPatterns/text.html.twig', ['nodes' => $expected]);
+
+        $this->assertEquals($expected, $handler->convert($node));
+    }
+
+    public function nonElementProvider() : iterable
+    {
+        yield 'cdata' => ['<![CDATA[<cdata>]]>', '<cdata>'];
+        yield 'comment' => ['<!--comment-->'];
+        yield 'processing instruction' => ['<?processing instruction?>'];
+        yield 'text' => ['text', 'text'];
+    }
+
     /**
      * @test
      */