Merge pull request #138 from lerna-stack/test-state-after-append-entries-handling

Test state after AppendEntries handling

Author: negokaz

src/test/scala/lerna/akka/entityreplication/raft/RaftActorCandidateSpec.scala

@@ -309,7 +309,10 @@ class RaftActorCandidateSpec extends TestKit(ActorSystem()) with RaftActorSpecBa
       candidate ! createAppendEntries(shardId, term2, anotherMemberIndex)
       expectMsg(AppendEntriesSucceeded(term2, LogEntryIndex(0), candidateMemberIndex))
 
-      getState(candidate).stateName should be(Follower)
+      val state = getState(candidate)
+      state.stateName should be(Follower)
+      state.stateData.currentTerm should be(term2)
+      state.stateData.leaderMember should contain(anotherMemberIndex)
     }
 
     "AppendEntries が同じ Term を持っているときは（先に別のリーダーが当選したということなので）Follower に降格" in {
@@ -324,7 +327,9 @@ class RaftActorCandidateSpec extends TestKit(ActorSystem()) with RaftActorSpecBa
       candidate ! createAppendEntries(shardId, term, anotherMemberIndex)
       expectMsg(AppendEntriesSucceeded(term, LogEntryIndex(0), candidateMemberIndex))
 
-      getState(candidate).stateName should be(Follower)
+      val state = getState(candidate)
+      state.stateName should be(Follower)
+      state.stateData.leaderMember should contain(anotherMemberIndex)
     }
 
     "コマンドは保留し、フォロワーに降格した場合はリーダーに転送する" in {
@@ -440,6 +445,10 @@ class RaftActorCandidateSpec extends TestKit(ActorSystem()) with RaftActorSpecBa
       setState(candidate, Candidate, candidateData)
       candidate ! createAppendEntries(shardId, term1, leaderMemberIndex, index3, term1)
       expectMsg(AppendEntriesFailed(term1, candidateMemberIndex))
+
+      val state = getState(candidate)
+      state.stateName should be(Follower)
+      state.stateData.leaderMember should contain(leaderMemberIndex)
     }
 
     "prevLogIndex の Term が prevLogTerm に一致するログエントリでない場合は AppendEntriesFailed を返す" in {
@@ -497,6 +506,7 @@ class RaftActorCandidateSpec extends TestKit(ActorSystem()) with RaftActorSpecBa
       val state = getState(candidate)
       state.stateName should be(Follower)
       state.stateData.currentTerm should be(leaderTerm)
+      state.stateData.leaderMember should contain(leaderMemberIndex)
     }
 
     "leaderCommit > commitIndex となる場合、 commitIndex に min(leaderCommit, 新規エントリの最後のインデックス) を設定" in {

src/test/scala/lerna/akka/entityreplication/raft/RaftActorFollowerSpec.scala

@@ -207,6 +207,10 @@ class RaftActorFollowerSpec extends TestKit(ActorSystem()) with RaftActorSpecBas
       val leaderMemberIndex = candidateMemberIndex
       follower ! createAppendEntries(shardId, term, leaderMemberIndex)
       expectMsg(AppendEntriesSucceeded(term, LogEntryIndex(0), followerMemberIndex))
+
+      val state = getState(follower)
+      state.stateName should be(Follower)
+      state.stateData.leaderMember should contain(leaderMemberIndex)
     }
 
     "自分が持っている Term より新しい場合は AppendEntries を成功させる" in {
@@ -227,6 +231,11 @@ class RaftActorFollowerSpec extends TestKit(ActorSystem()) with RaftActorSpecBas
       val leaderMemberIndex = candidateMemberIndex
       follower ! createAppendEntries(shardId, term2, leaderMemberIndex)
       expectMsg(AppendEntriesSucceeded(term2, LogEntryIndex(0), followerMemberIndex))
+
+      val state = getState(follower)
+      state.stateName should be(Follower)
+      state.stateData.currentTerm should be(term2)
+      state.stateData.leaderMember should contain(leaderMemberIndex)
     }
 
     "自分が持っている Term より古い場合は AppendEntries を失敗させる" in {
@@ -494,6 +503,10 @@ class RaftActorFollowerSpec extends TestKit(ActorSystem()) with RaftActorSpecBas
         logEntries,
       )
       expectMsg(AppendEntriesFailed(term1, followerMemberIndex))
+
+      val state = getState(follower)
+      state.stateName should be(Follower)
+      state.stateData.leaderMember should contain(leaderMemberIndex)
     }
 
     "agree to a term if it receives AppendEntries which includes log entries that cannot be merged and newer Term" in {
@@ -598,6 +611,10 @@ class RaftActorFollowerSpec extends TestKit(ActorSystem()) with RaftActorSpecBas
         followerLogEntries.last.term.next(),
       )
       expectMsg(AppendEntriesFailed(term1, followerMemberIndex))
+
+      val state = getState(follower)
+      state.stateName should be(Follower)
+      state.stateData.leaderMember should contain(leaderMemberIndex)
     }
 
   }

src/test/scala/lerna/akka/entityreplication/raft/RaftActorLeaderSpec.scala

@@ -61,7 +61,10 @@ class RaftActorLeaderSpec extends TestKit(ActorSystem()) with RaftActorSpecBase
       leader ! createAppendEntries(shardId, term2, anotherMemberIndex)
       expectMsg(AppendEntriesSucceeded(term2, LogEntryIndex(0), leaderMemberIndex))
 
-      getState(leader).stateName should be(Follower)
+      val state = getState(leader)
+      state.stateName should be(Follower)
+      state.stateData.currentTerm should be(term2)
+      state.stateData.leaderMember should contain(anotherMemberIndex)
     }
 
     "コマンドを ReplicationActor に転送する" ignore {}
@@ -107,6 +110,11 @@ class RaftActorLeaderSpec extends TestKit(ActorSystem()) with RaftActorSpecBase
 
       leader ! createAppendEntries(shardId, term2, newLeaderMemberIndex, index3, term1, logEntries)
       expectMsg(AppendEntriesFailed(term2, leaderMemberIndex))
+
+      val state = getState(leader)
+      state.stateName should be(Follower)
+      state.stateData.currentTerm should be(term2)
+      state.stateData.leaderMember should contain(newLeaderMemberIndex)
     }
 
     "prevLogIndex の Term が prevLogTerm に一致するログエントリでない場合は AppendEntriesFailed を返す" in {