chore: use explicit undefined

Author: joelgallant

app-config-esbuild/src/index.ts

@@ -30,7 +30,7 @@ export const createPlugin = ({
       if (noBundledConfig) {
         const { validationFunctionCode } = await loadSchema(schemaLoadingOptions);
 
-        const code = generateModuleText('no-config', {
+        const code = generateModuleText(undefined, {
           environment: undefined,
           useGlobalNamespace: true,
           validationFunctionCode: injectValidationFunction ? validationFunctionCode : undefined,

app-config-rollup/src/index.ts

@@ -43,7 +43,7 @@ export default function appConfigRollup({
         if (noBundledConfig) {
           const { validationFunctionCode } = await loadSchema(schemaLoadingOptions);
 
-          return generateModuleText('no-config', {
+          return generateModuleText(undefined, {
             environment: undefined,
             useGlobalNamespace: true,
             validationFunctionCode: injectValidationFunction ? validationFunctionCode : undefined,

app-config-utils/src/__snapshots__/index.test.ts.snap

@@ -6,32 +6,13 @@ exports[`generateModuleText creates config module 1`] = `
 
       export { config };
       export default config;
-
+    
       export function currentEnvironment() {
         return \\"test\\";
       }
     "
 `;
 
-exports[`generateModuleText creates config module with noBundledConfig 1`] = `
-"
-      const globalNamespace = (typeof window === 'undefined' ? globalThis : window) || {};
-
-      const config = globalNamespace._appConfig;
-
-      if (typeof config === 'undefined') {
-        throw new Error('Config is not loaded in _appConfig');
-      }
-
-      export { config };
-      export default config;
-
-      export function currentEnvironment() {
-        return globalNamespace._appConfigEnvironment || \\"test\\";
-      }
-    "
-`;
-
 exports[`generateModuleText creates config module with esm validation function 1`] = `
 "
       const globalNamespace = (typeof window === 'undefined' ? globalThis : window) || {};
@@ -51,19 +32,19 @@ exports[`generateModuleText creates config module with esm validation function 1
 
       export { config };
       export default config;
-
+    
         const foo = 'bar';
 
-
+        
         function genValidateConfig(){
           const validateConfigModule = {};
           (function(module){import foo from \\"bar\\";})(validateConfigModule);
           return validateConfigModule.exports;
         }
 
-
+        
         export const validateConfig = /*#__PURE__*/ genValidateConfig();
-
+      
       export function currentEnvironment() {
         return globalNamespace._appConfigEnvironment || \\"test\\";
       }
@@ -89,7 +70,26 @@ exports[`generateModuleText creates config module with global namespace 1`] = `
 
       export { config };
       export default config;
+    
+      export function currentEnvironment() {
+        return globalNamespace._appConfigEnvironment || \\"test\\";
+      }
+    "
+`;
+
+exports[`generateModuleText creates config module with noBundledConfig 1`] = `
+"
+      const globalNamespace = (typeof window === 'undefined' ? globalThis : window) || {};
+
+      const config = globalNamespace._appConfig;
+
+      if (typeof config === 'undefined') {
+        throw new Error('Config is not loaded in _appConfig');
+      }
 
+      export { config };
+      export default config;
+    
       export function currentEnvironment() {
         return globalNamespace._appConfigEnvironment || \\"test\\";
       }
@@ -115,8 +115,8 @@ exports[`generateModuleText creates config module with validation function 1`] =
 
       export { config };
       export default config;
-
-
+    
+        
         function genValidateConfig(){
           const validateConfigModule = {};
           (function(module){
@@ -125,9 +125,9 @@ exports[`generateModuleText creates config module with validation function 1`] =
           return validateConfigModule.exports;
         }
 
-
+        
         export const validateConfig = /*#__PURE__*/ genValidateConfig();
-
+      
       export function currentEnvironment() {
         return globalNamespace._appConfigEnvironment || \\"test\\";
       }

app-config-utils/src/index.test.ts

@@ -61,7 +61,7 @@ describe('generateModuleText', () => {
 
   it('creates config module with noBundledConfig', () => {
     expect(
-      generateModuleText('no-config', {
+      generateModuleText(undefined, {
         environment: 'test',
         useGlobalNamespace: true,
         esmValidationCode: false,

app-config-utils/src/index.ts

@@ -26,7 +26,7 @@ export function isPrimitive(obj: Json): obj is JsonPrimitive {
 }
 
 export function generateModuleText(
-  fullConfig: Json | 'no-config',
+  fullConfig: Json | undefined,
   {
     environment,
     useGlobalNamespace,
@@ -45,7 +45,7 @@ export function generateModuleText(
 
   let generatedText = '';
 
-  if (fullConfig === 'no-config') {
+  if (fullConfig === undefined) {
     generatedText += `
       const globalNamespace = (typeof window === 'undefined' ? globalThis : window) || {};
 

app-config-webpack/src/loader.ts

@@ -27,7 +27,7 @@ const loader = function AppConfigLoader(this: Loader) {
       .then(({ validationFunctionCode }) => {
         callback(
           null,
-          generateModuleText('no-config', {
+          generateModuleText(undefined, {
             environment: undefined,
             useGlobalNamespace: true,
             validationFunctionCode: injectValidationFunction ? validationFunctionCode : undefined,