Merge pull request #54 from larus-breeze/sw_sensor_issue_117

Simplify used eeprom interface in algorithm

Author: MaxBaex

NAV_Algorithms/AHRS.cpp

@@ -399,12 +399,8 @@ void AHRS_type::write_calibration_into_EEPROM( void)
   if( !magnetic_calibration_updated)
     return;
 
-  lock_EEPROM( false);
-
   compass_calibration.write_into_EEPROM();
   magnetic_calibration_updated = false; // done ...
-
-  lock_EEPROM( true);
 }
 
 void AHRS_type::handle_magnetic_calibration ( void)

NAV_Algorithms/compass_calibration.h

@@ -175,8 +175,6 @@ template <class sample_type, class evaluation_type> class compass_calibration_t
     if( calibration_done == false)
       return;
 
-    EEPROM_initialize();
-
     float variance = 0.0f;
     for( unsigned i=0; i<3; ++i)
       {

NAV_Algorithms/organizer.h

@@ -82,11 +82,9 @@ class organizer_t
     eulerangle<float> euler = q;
 
     // make the change permanent
-    lock_EEPROM( false);
     write_EEPROM_value( SENS_TILT_ROLL,  euler.roll);
     write_EEPROM_value( SENS_TILT_PITCH, euler.pitch);
     write_EEPROM_value( SENS_TILT_YAW,   euler.yaw);
-    lock_EEPROM( true);
   }
 
   void fine_tune_sensor_orientation( const vector_average_collection_t & values)
@@ -110,11 +108,9 @@ class organizer_t
     eulerangle<float> new_euler = q_new_setting;
 
     // make the change permanent
-    lock_EEPROM( false);
     write_EEPROM_value( SENS_TILT_ROLL,  new_euler.roll);
     write_EEPROM_value( SENS_TILT_PITCH, new_euler.pitch);
     write_EEPROM_value( SENS_TILT_YAW,   new_euler.yaw);
-    lock_EEPROM( true);
   }
 
   void initialize_before_measurement( void)

NAV_Algorithms/persistent_data.cpp

@@ -76,24 +76,16 @@ bool all_EEPROM_parameters_available( void)
 
 void ensure_EEPROM_parameter_integrity( void)
 {
-  bool EEPROM_has_been_unlocked = false;
   float dummy;
   const persistent_data_t * parameter = PERSISTENT_DATA;
   while( parameter < PERSISTENT_DATA + PERSISTENT_DATA_ENTRIES)
     {
       if( true == read_EEPROM_value( parameter->id, dummy)) // parameter missing
 	{
-	  if( EEPROM_has_been_unlocked == false)
-	    {
-	      lock_EEPROM( false);
-	      EEPROM_has_been_unlocked = true;
-	    }
 	  (void) write_EEPROM_value( parameter->id, parameter->default_value);
 	}
       ++parameter;
     }
-  if( EEPROM_has_been_unlocked)
-    lock_EEPROM( true);
 }
 
 const persistent_data_t * find_parameter_from_name( char * name)
@@ -219,33 +211,19 @@ bool EEPROM_convert( EEPROM_PARAMETER_ID id, EEPROM_data_t & EEPROM_value, float
   return false; // OK
 }
 
-bool lock_EEPROM( bool lockit)
-{
-  if( lockit)
-    return HAL_FLASH_Lock();
-
-  HAL_FLASH_Unlock();
-  return (EE_Init());
-}
-
 bool write_EEPROM_value( EEPROM_PARAMETER_ID id, float value)
 {
   EEPROM_data_t EEPROM_value;
   if( EEPROM_convert( id, EEPROM_value, value , WRITE))
       return true; // error
 
-  EEPROM_data_t read_value;
-  if( (HAL_OK != EE_ReadVariable( id, &read_value.u16))
-      ||
-      (read_value.u16 != EEPROM_value.u16) )
-	return EE_WriteVariable( id, EEPROM_value.u16);
-  return HAL_OK;
+  return EE_WriteVariableBuffered( id, EEPROM_value.u16);
 }
 
 bool read_EEPROM_value( EEPROM_PARAMETER_ID id, float &value)
 {
   uint16_t data;
-  if( HAL_OK != EE_ReadVariable( id, (uint16_t*)&data))
+  if( HAL_OK != EE_ReadVariableBuffered( id, (uint16_t*)&data))
     return true;
   return ( EEPROM_convert( id, (EEPROM_data_t &)data, value , READ));
 }
@@ -258,17 +236,4 @@ float configuration( EEPROM_PARAMETER_ID id)
   return value;
 }
 
-bool EEPROM_initialize( void)
-{
-  unsigned status;
-
-  status = HAL_FLASH_Unlock();
-  ASSERT(status == HAL_OK);
-
-  status = EE_Init();
-  ASSERT(status == HAL_OK);
-
-  return HAL_OK;
-}
-
 #endif

NAV_Algorithms/persistent_data.h

@@ -95,8 +95,6 @@ const persistent_data_t * find_parameter_from_ID( EEPROM_PARAMETER_ID id);
 float configuration( EEPROM_PARAMETER_ID id);
 bool write_EEPROM_value( EEPROM_PARAMETER_ID id, float value);
 bool read_EEPROM_value( EEPROM_PARAMETER_ID id, float &value);
-bool lock_EEPROM( bool lockit);
-bool EEPROM_initialize( void);
 void ensure_EEPROM_parameter_integrity(void);
 
 extern const persistent_data_t PERSISTENT_DATA[];