PYTHON-5401: Revise PR template for improved clarity and checks #279
+4
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blink1073
reviewed
Dec 1, 2025
| @@ -1,4 +1,4 @@ | |||
| [Issue Key](https://jira.mongodb.org/browse/{ISSUE_KEY}) | |||
| [JIRA TICKET](https://jira.mongodb.org/browse/{ISSUE_KEY}) | |||
Collaborator
There was a problem hiding this comment.
I thought we were going to let the autolink work for this?
Collaborator
There was a problem hiding this comment.
Autolink from the title?
Collaborator
Author
|
@Jibola make sure to add the blurb about the usage of AI |
caseyclements
requested changes
Dec 1, 2025
Collaborator
caseyclements
left a comment
caseyclements
left a comment
There was a problem hiding this comment.
Please review the checklists.
| @@ -1,4 +1,4 @@ | |||
| [Issue Key](https://jira.mongodb.org/browse/{ISSUE_KEY}) | |||
| [JIRA TICKET](https://jira.mongodb.org/browse/{ISSUE_KEY}) | |||
Collaborator
There was a problem hiding this comment.
Autolink from the title?
| - [ ] Is the intention of the code captured in relevant tests? | ||
| - [ ] If there are new TODOs, has a related JIRA ticket been created? | ||
| - [ ] Does the title of the PR reference a JIRA Ticket? | ||
| - [ ] Do you fully understand the implementation? (Would you be comfortable explaining how this code works to someone else?) |
Collaborator
There was a problem hiding this comment.
"Do you fully understand..." This line is for the Reviewer. Doubled here.
| - [ ] Does the title of the PR reference a JIRA Ticket? | ||
| - [ ] Do you fully understand the implementation? (Would you be comfortable explaining how this code works to someone else?) | ||
| - [ ] Is all relevant documentation (README or docstring) updated? | ||
| - [ ] Has a MongoDB Employee run [the patch build of this PR](https://github.com/mongodb-labs/ai-ml-pipeline-testing?tab=readme-ov-file#running-a-patch-build-of-a-given-pr)? |
Collaborator
There was a problem hiding this comment.
The patch build line might be a line for the reviewer, too.
|
|
||
| ### Checklist for Author | ||
|
|
||
| - [ ] Did you update the changelog (if necessary)? |
Collaborator
There was a problem hiding this comment.
The changelog and relevant tests should still be there, no?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PYTHON-5401
Changes in this PR
Updated the pull request template to improve clarity and consistency in formatting.
Changed components of the PR template relative to this agreed upon doc
Test Plan
Test in prod
Checklist
Checklist for Author
Checklist for Reviewer