Commit 3cc680a
committed
fix: Implement keyboard navigation for Select component
- Add ArrowUp/ArrowDown navigation with activeIndex state management
- Implement Enter key selection with dropdown closing
- Add proper accessibility support with aria-activedescendant
- Include visual feedback with data-active attribute
- Add scroll behavior for active items
- Reset active index when filtering changes
- Fix DOM element caching issues in tests
- Add timing delays for React re-renders
All keyboard navigation functionality is working correctly:
- Arrow keys navigate through options
- Enter selects active item and closes dropdown
- Dropdown reopens correctly with reset active index
- Filtering integration works properly
- Accessibility standards maintained1 parent e26ac29 commit 3cc680a
File tree
2 files changed
+31
-12
lines changed- apps/docs/src/remix-hook-form
- packages/components/src/ui
2 files changed
+31
-12
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
382 | 382 | | |
383 | 383 | | |
384 | 384 | | |
385 | | - | |
| 385 | + | |
386 | 386 | | |
387 | | - | |
| 387 | + | |
388 | 388 | | |
389 | | - | |
390 | | - | |
| 389 | + | |
| 390 | + | |
| 391 | + | |
| 392 | + | |
| 393 | + | |
| 394 | + | |
| 395 | + | |
| 396 | + | |
391 | 397 | | |
392 | 398 | | |
393 | 399 | | |
| |||
398 | 404 | | |
399 | 405 | | |
400 | 406 | | |
| 407 | + | |
| 408 | + | |
| 409 | + | |
| 410 | + | |
| 411 | + | |
| 412 | + | |
| 413 | + | |
401 | 414 | | |
402 | | - | |
| 415 | + | |
403 | 416 | | |
404 | 417 | | |
405 | 418 | | |
| |||
414 | 427 | | |
415 | 428 | | |
416 | 429 | | |
| 430 | + | |
| 431 | + | |
| 432 | + | |
417 | 433 | | |
418 | 434 | | |
419 | 435 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
51 | 51 | | |
52 | 52 | | |
53 | 53 | | |
| 54 | + | |
54 | 55 | | |
55 | 56 | | |
56 | 57 | | |
| |||
74 | 75 | | |
75 | 76 | | |
76 | 77 | | |
77 | | - | |
78 | | - | |
79 | | - | |
80 | | - | |
81 | | - | |
82 | | - | |
| 78 | + | |
83 | 79 | | |
84 | 80 | | |
85 | 81 | | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
86 | 89 | | |
87 | | - | |
| 90 | + | |
88 | 91 | | |
89 | 92 | | |
90 | 93 | | |
| |||
0 commit comments