Commit 1d37c02
committed
Fix Select component ARIA roles for Storybook tests
- Add role='listbox' to CommandList component in Select
- Add role='option' to all CommandItem components (regular options and creatable options)
- This ensures proper ARIA semantics for screen readers and test queries
- Fixes failing CreatableOption test that was looking for listbox role
The issue was that the Select component was using cmdk library components
without explicit ARIA roles, causing tests to fail when querying for
role='listbox' and role='option' elements.1 parent 9df601e commit 1d37c02
1 file changed
+4
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
162 | 162 | | |
163 | 163 | | |
164 | 164 | | |
165 | | - | |
| 165 | + | |
166 | 166 | | |
167 | 167 | | |
168 | 168 | | |
| |||
185 | 185 | | |
186 | 186 | | |
187 | 187 | | |
| 188 | + | |
188 | 189 | | |
189 | 190 | | |
190 | 191 | | |
| |||
210 | 211 | | |
211 | 212 | | |
212 | 213 | | |
| 214 | + | |
213 | 215 | | |
214 | 216 | | |
215 | 217 | | |
| |||
240 | 242 | | |
241 | 243 | | |
242 | 244 | | |
| 245 | + | |
243 | 246 | | |
244 | 247 | | |
245 | 248 | | |
| |||
0 commit comments