Skip to content

Commit a6804cc

Browse files
committed
addressing comments
1 parent 6d348eb commit a6804cc

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

e2e/src/test/groovy/io/kubernetes/client/e2e/util/ModelMapperTest.groovy

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,14 +24,13 @@ import spock.lang.Specification
2424

2525
class ModelMapperTest extends Specification {
2626

27-
def "api-disocvery should work"() {
27+
def "api-discovery should work"() {
2828
given:
2929
def apiClient = ClientBuilder.defaultClient();
3030
def discovery = new Discovery(apiClient)
3131
ModelMapper.refresh(discovery);
3232

3333
expect:
34-
3534
new GroupVersionKind("", "v1", "Pod") == ModelMapper.getGroupVersionKindByClass(V1Pod.class)
3635
new GroupVersionResource("", "v1", "pods") == ModelMapper.getGroupVersionResourceByClass(V1Pod.class)
3736

util/src/main/java/io/kubernetes/client/util/ModelMapper.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,8 +53,10 @@ public class ModelMapper {
5353
// Model's api-version midfix to kubernetes api-version
5454
private static List<String> preBuiltApiVersions = new ArrayList<>();
5555

56+
// TODO(yue9944882): make the map bi-directional
5657
private static Map<GroupVersionKind, Class<?>> classesByGVK = new ConcurrentHashMap<>();
5758

59+
// TODO(yue9944882): make the map bi-directional
5860
private static Map<GroupVersionResource, Class<?>> classesByGVR = new ConcurrentHashMap<>();
5961

6062
private static Set<Discovery.APIResource> lastAPIDiscovery = new HashSet<>();

0 commit comments

Comments
 (0)