refactor: review rework to use assert throws

Author: at88mph

util/src/test/java/io/kubernetes/client/MetricsTest.java

@@ -16,6 +16,7 @@
 import static com.github.tomakehurst.wiremock.core.WireMockConfiguration.options;
 import static org.assertj.core.api.Assertions.assertThat;
 import static org.assertj.core.api.Assertions.failBecauseExceptionWasNotThrown;
+import static org.junit.jupiter.api.Assertions.assertThrows;
 
 import com.github.tomakehurst.wiremock.junit5.WireMockExtension;
 import io.kubernetes.client.openapi.ApiClient;
@@ -49,31 +50,21 @@ void getPodMetricsThrowsAPIExceptionWhenServerReturnsError() {
                     .withStatus(503)
                     .withHeader("Content-Type", "text/plain")
                     .withBody("Service Unavailable")));
-    try {
-      metrics.getPodMetrics(namespace);
-      failBecauseExceptionWasNotThrown(ApiException.class);
-    } catch (ApiException ex) {
-      assertThat(ex.getCode()).isEqualTo(503);
-    }
+      assertThrows(ApiException.class, () -> metrics.getPodMetrics(namespace));
   }
 
   @Test
   void getPodMetricsWithLabelSelectorThrowsAPIExceptionWhenServerReturnsError() {
     String namespace = "default";
     Metrics metrics = new Metrics(client);
     apiServer.stubFor(
-            get(urlPathMatching("^/apis/metrics.k8s.io/v1beta1/namespaces/" + namespace + "/pods.*"))
-                    .willReturn(
-                            aResponse()
-                                    .withStatus(503)
-                                    .withHeader("Content-Type", "text/plain")
-                                    .withBody("Service Unavailable")));
-    try {
-      metrics.getPodMetrics(namespace, "foo=bar");
-      failBecauseExceptionWasNotThrown(ApiException.class);
-    } catch (ApiException ex) {
-      assertThat(ex.getCode()).isEqualTo(503);
-    }
+        get(urlPathMatching("^/apis/metrics.k8s.io/v1beta1/namespaces/" + namespace + "/pods.*"))
+            .willReturn(
+                aResponse()
+                    .withStatus(503)
+                    .withHeader("Content-Type", "text/plain")
+                    .withBody("Service Unavailable")));
+    assertThrows(ApiException.class, () -> metrics.getPodMetrics(namespace, "foo=bar"));
   }
 
   @Test
@@ -86,11 +77,6 @@ void getNodeMetricsThrowsAPIExceptionWhenServerReturnsError() {
                     .withStatus(503)
                     .withHeader("Content-Type", "text/plain")
                     .withBody("Service Unavailable")));
-    try {
-      metrics.getNodeMetrics();
-      failBecauseExceptionWasNotThrown(ApiException.class);
-    } catch (ApiException ex) {
-      assertThat(ex.getCode()).isEqualTo(503);
-    }
+      assertThrows(ApiException.class, metrics::getNodeMetrics);
   }
 }