Merge pull request #1252 from yue9944882/refactor/generic-api-failure-flow

Refactor: Generic kubernetes api failure flow

Author: k8s-ci-robot

examples/src/main/java/io/kubernetes/client/examples/GenericClientExample.java

@@ -14,6 +14,7 @@
 
 import io.kubernetes.client.custom.V1Patch;
 import io.kubernetes.client.openapi.ApiClient;
+import io.kubernetes.client.openapi.ApiException;
 import io.kubernetes.client.openapi.models.V1Container;
 import io.kubernetes.client.openapi.models.V1ObjectMeta;
 import io.kubernetes.client.openapi.models.V1Pod;
@@ -45,7 +46,7 @@ public static void main(String[] args) throws Exception {
             .onFailure(
                 errorStatus -> {
                   System.out.println("Not Created!");
-                  throw new RuntimeException(errorStatus.toString());
+                  throw new ApiException(errorStatus.toString());
                 })
             .getObject();
     System.out.println("Created!");
@@ -60,7 +61,7 @@ public static void main(String[] args) throws Exception {
             .onFailure(
                 errorStatus -> {
                   System.out.println("Not Patched!");
-                  throw new RuntimeException(errorStatus.toString());
+                  throw new ApiException(errorStatus.toString());
                 })
             .getObject();
     System.out.println("Patched!");
@@ -71,7 +72,7 @@ public static void main(String[] args) throws Exception {
             .onFailure(
                 errorStatus -> {
                   System.out.println("Not Deleted!");
-                  throw new RuntimeException(errorStatus.toString());
+                  throw new ApiException(errorStatus.toString());
                 })
             .getObject();
     if (deletedPod != null) {

util/src/main/java/io/kubernetes/client/informer/SharedInformerFactory.java

@@ -24,7 +24,6 @@
 import io.kubernetes.client.util.Watch;
 import io.kubernetes.client.util.Watchable;
 import io.kubernetes.client.util.generic.GenericKubernetesApi;
-import io.kubernetes.client.util.generic.KubernetesApiResponse;
 import io.kubernetes.client.util.generic.options.ListOptions;
 import java.lang.reflect.Type;
 import java.util.HashMap;
@@ -205,18 +204,19 @@ ListerWatcher<ApiType, ApiListType> listerWatcherFor(
     }
     return new ListerWatcher<ApiType, ApiListType>() {
       public ApiListType list(CallGeneratorParams params) throws ApiException {
-        KubernetesApiResponse<ApiListType> resp =
-            genericKubernetesApi.list(
+        return genericKubernetesApi
+            .list(
                 new ListOptions() {
                   {
                     setResourceVersion(params.resourceVersion);
                     setTimeoutSeconds(params.timeoutSeconds);
                   }
-                });
-        if (!resp.isSuccess()) {
-          throw new ApiException(resp.getHttpStatusCode(), resp.getStatus().getMessage());
-        }
-        return resp.getObject();
+                })
+            .onFailure(
+                errorStatus -> {
+                  throw new ApiException(errorStatus.toString());
+                })
+            .getObject();
       }
 
       public Watchable<ApiType> watch(CallGeneratorParams params) throws ApiException {