Skip to content

Commit e311f6f

Browse files
author
Hen Schwartz
committed
Upgrade Go to 1.24 for pvcviewer-controller
- Update CI workflow pvcviewer_controller_unit_test.yaml to use go-version 1.24 - Update go.mod to go 1.24 - Update Dockerfile GOLANG_VERSION to 1.24 Signed-off-by: Hen Schwartz <hschwart@hschwart-thinkpadp1gen7.raanaii.csb>
1 parent 0b835a7 commit e311f6f

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

.github/workflows/pvcviewer_controller_unit_test.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ jobs:
1919
- name: Install Go
2020
uses: actions/setup-go@v5
2121
with:
22-
go-version: "1.22.2"
22+
go-version-file: 'components/pvcviewer-controller/go.mod'
2323
check-latest: true
2424

2525
- name: Run unit tests

components/pvcviewer-controller/Dockerfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
# Build the manager binary
2-
ARG GOLANG_VERSION=1.22.2
2+
ARG GOLANG_VERSION=1.24
33
FROM golang:${GOLANG_VERSION} as builder
44

55
WORKDIR /workspace
@@ -16,7 +16,7 @@ COPY pvcviewer-controller/api/ api/
1616
COPY pvcviewer-controller/controllers/ controllers/
1717

1818
# Build
19-
RUN CGO_ENABLED=0 GOOS=linux GO111MODULE=on go build -a -mod=mod -o manager main.go
19+
RUN CGO_ENABLED=0 GOOS=linux go build -a -o manager main.go
2020

2121
# Use distroless as minimal base image to package the manager binary
2222
# Refer to https://github.com/GoogleContainerTools/distroless for more details

components/pvcviewer-controller/go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
module github.com/kubeflow/notebooks/components/pvcviewer-controller
22

3-
go 1.22.2
3+
go 1.24
44

55
require (
66
github.com/go-logr/logr v1.4.1

0 commit comments

Comments
 (0)