Skip to content

Commit 00d8002

Browse files
author
Arvind Thirumurugan
committed
minor fixes
Signed-off-by: Arvind Thirumurugan <arvindth@microsoft.com>
1 parent d1999c7 commit 00d8002

File tree

3 files changed

+3
-4
lines changed

3 files changed

+3
-4
lines changed

pkg/controllers/updaterun/execution.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -235,13 +235,12 @@ func (r *Reconciler) executeUpdatingStage(
235235
stuckClusterNames = append(stuckClusterNames, clusterStatus.ClusterName)
236236
}
237237
}
238-
// Need to continue as we need to process at most maxConcurrency number of clusters in parallel.
239238
}
240239

241240
// After processing maxConcurrency number of cluster, check if we need to mark the update run as stuck or progressing.
242241
aggregateUpdateRunStatus(updateRun, updatingStageStatus.StageName, stuckClusterNames, finishedClusterCount)
243242

244-
// After processing all clusters, aggregate and return errors
243+
// After processing all clusters, aggregate and return errors.
245244
if len(clusterUpdateErrors) > 0 {
246245
return 0, utilerrors.NewAggregate(clusterUpdateErrors)
247246
}

test/e2e/cluster_staged_updaterun_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1314,7 +1314,7 @@ var _ = Describe("test CRP rollout with staged update run", func() {
13141314
},
13151315
},
13161316
}
1317-
Expect(hubClient.Create(ctx, strategy)).To(Succeed(), "Failed to create ClusterStagedUpdateStrategy with maxConcurrency=3")
1317+
Expect(hubClient.Create(ctx, strategy)).To(Succeed(), "Failed to create ClusterStagedUpdateStrategy")
13181318
})
13191319

13201320
AfterAll(func() {

test/e2e/staged_updaterun_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1143,7 +1143,7 @@ var _ = Describe("test RP rollout with staged update run", Label("resourceplacem
11431143
},
11441144
},
11451145
}
1146-
Expect(hubClient.Create(ctx, strategy)).To(Succeed(), "Failed to create StagedUpdateStrategy with maxConcurrency=3")
1146+
Expect(hubClient.Create(ctx, strategy)).To(Succeed(), "Failed to create StagedUpdateStrategy")
11471147
})
11481148

11491149
AfterAll(func() {

0 commit comments

Comments
 (0)